search

gamenet / redis-memory-analyzer

Redis memory profiler to find the RAM bottlenecks throw scaning key space in real time and aggregate RAM usage statistic by patterns.
MIT License
772 stars 80 forks source link

custom patterns, more tolerant to empty values. #31

Closed guyromm closed 7 years ago

guyromm commented 7 years ago

hi there. these changes were required in order to fix patterns in my specific scenario.

i think it would be nice if the ability to include a custom transformation function for the pattern generator could be generalized (as opposed to my hardcoded change), though i'm not quite sure how.

additionally, i was forced to make the field/value min/max functionality more resilient to empty sets

misterion commented 7 years ago

@pr0head could you check it out and deploy new version to pip?

guyromm commented 7 years ago

the provided changeset is but an example for how a user (e.g: me) would want to correct the stemming when running analysis on a specific redis instance. in my case it was python-celery + kombu polluting the server with "unpatternable" keys..

i would advise against merging as is. what's needed is a more elegant ability to customize by each to his/her needs.

misterion commented 7 years ago

@guyromm this alows to find fast solution for existing problem. So we can fast merge it and began to use it right now. In the meantime, to find time for the ideal solution.