search

gameontext / gameon-mediator

The mediator between the device (phone, browser, ... ) and rooms, items, and other backend services.
Apache License 2.0
5 stars 7 forks source link

Improve information provided by First Room, some refinements to /help #67

Closed ebullient closed 8 years ago

ebullient commented 8 years ago

Fixes gameontext/gameon#72 Fixes gameontext/gameon#73 Fixes gameontext/gameon#76 Fixes gameontext/gameon#77

Signed-off-by: Erin Schnabel schnabel@us.ibm.com

This change is Reviewable

BarDweller commented 8 years ago

Review status: 0 of 11 files reviewed at latest revision, 2 unresolved discussions.

mediator-app/src/main/java/org/gameontext/mediator/Constants.java, line 79 at r1 (raw file):

    JsonObject COMMON_COMMANDS = Json.createObjectBuilder()
            .add("/exits", "List room exits")
            .add("/examine", "Examine an item. Implementaitons will vary: this may be similar to look, or may not work at all")

typo. implementations

mediator-app/src/main/java/org/gameontext/mediator/Constants.java, line 81 at r1 (raw file):

            .add("/examine", "Examine an item. Implementaitons will vary: this may be similar to look, or may not work at all")
            .add("/go", "Exit the room using the specified door, e.g. `/go N`")
            .add("/look", "Describe a room or an item. Implementaitons will vary")

typo.. implementations

Comments from Reviewable

BarDweller commented 8 years ago

Reviewed 13 of 14 files at r1. Review status: 10 of 11 files reviewed at latest revision, 3 unresolved discussions.

mediator-wlpcfg/startup.sh, line 50 at r1 (raw file):


  GAMEON_MODE=$(etcdctl get /global/mode)
  export GAMEON_MODE=${GAMEON_MODE:-production}

does something need this set now? I can see this forces the value to production if it didnt get a value from etcd, wasnt aware of anything checking for 'production' state tho.

Comments from Reviewable

ebullient commented 8 years ago

Review status: 9 of 11 files reviewed at latest revision, 3 unresolved discussions.

mediator-wlpcfg/startup.sh, line 50 at r1 (raw file):

Previously, BarDweller (Ozzy Osborne) wrote… > does something need this set now? I can see this forces the value to production if it didnt get a value from etcd, wasnt aware of anything checking for 'production' state tho. >

Related to the changes in server.xml to use the env var to pick up overrides (and skip the copies):

Comments from Reviewable

ebullient commented 8 years ago

Review status: 9 of 11 files reviewed at latest revision, 3 unresolved discussions.

mediator-wlpcfg/startup.sh, line 50 at r1 (raw file):

Previously, ebullient (Erin Schnabel) wrote… > Related to the changes in server.xml to use the env var to pick up overrides (and skip the copies): > > > >

<include location="${env.GAMEON_MODE}-local.xml" optional="true" /> <include location="${env.GAMEON_MODE}-logCollector.xml" optional="true" /> <include location="${env.GAMEON_MODE}-messageHub.xml" optional="true" />

Comments from Reviewable

ebullient commented 8 years ago

Review status: 9 of 11 files reviewed at latest revision, 3 unresolved discussions.

mediator-app/src/main/java/org/gameontext/mediator/Constants.java, line 79 at r1 (raw file):

Previously, BarDweller (Ozzy Osborne) wrote… > typo. implementations >

Done.

mediator-app/src/main/java/org/gameontext/mediator/Constants.java, line 81 at r1 (raw file):

Previously, BarDweller (Ozzy Osborne) wrote… > typo.. implementations >

Done.

Comments from Reviewable

BarDweller commented 8 years ago

Review status: 9 of 11 files reviewed at latest revision, 1 unresolved discussion.

mediator-wlpcfg/startup.sh, line 50 at r1 (raw file):

Previously, ebullient (Erin Schnabel) wrote… > <include location="${env.GAMEON_MODE}-local.xml" optional="true" /> > <include location="${env.GAMEON_MODE}-logCollector.xml" optional="true" /> > <include location="${env.GAMEON_MODE}-messageHub.xml" optional="true" /> >

Aha.. I'd seen that but missed the connection, cute.

Comments from Reviewable

BarDweller commented 8 years ago

Reviewed 2 of 2 files at r2. Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable