Closed katheris closed 8 years ago
Review status: 0 of 1 files reviewed at latest revision, 10 unresolved discussions.
README.md, line 44 at r1 (raw file):
or * [Deploy using Docker](#deploy-using-docker)
Coming out of either step, you should have cut/paste of the websocket URL you need for room registration
README.md, line 47 at r1 (raw file):
## Registering your room Microservices in production should support automatic scaling, with multiple instances of the room microservice running in parallel, with new instances starting or existing instances stopping at unpredictable times. As a result of this, the room does not programmatically register itself by default. You can force it to do so by specifying the GAMEON_ID and GAMEON_SECRET environment variables.
We should remove the above. All signs of registration code in the room should be removed.
README.md, line 50 at r1 (raw file):
The preferred way to register a room is via the Edit Rooms dialog in Game On! (note you can also use the [command line regutil tool](https://github.com/gameontext/regutil) or the [interactive map](https://game-on.org/interactivemap)).
Take the above out. "Use the Edit Rooms dialog in Game On! to register your room: "
README.md, line 59 at r1 (raw file):
## Access room on Game On!
Visit your room in the game (Hello, World!)
README.md, line 60 at r1 (raw file):
## Access room on Game On! Once the room is set up and it has registered with Game On!, it will be accessible on [Game On!](https://game-on.org/). It may take a moment for the room to appear.
...it will be accessible as a room in the game.
README.md, line 62 at r1 (raw file):
Once the room is set up and it has registered with Game On!, it will be accessible on [Game On!](https://game-on.org/). It may take a moment for the room to appear. 1. Log in to [Game On!](https://game-on.org/) using the authentication method you used to create your user ID and shared secret for the registered room.
If you aren't in The First Room, use /sos
to return there.
README.md, line 63 at r1 (raw file):
1. Log in to [Game On!](https://game-on.org/) using the authentication method you used to create your user ID and shared secret for the registered room. 2. Use the Game On! command `/listmyrooms` from The First Room, to see your list of rooms. Once your room is registered, it will appear in that list.
"Your newly registered room should appear in the list"
README.md, line 64 at r1 (raw file):
1. Log in to [Game On!](https://game-on.org/) using the authentication method you used to create your user ID and shared secret for the registered room. 2. Use the Game On! command `/listmyrooms` from The First Room, to see your list of rooms. Once your room is registered, it will appear in that list. 3. To get to your room, navigate through the network or go directly there by using the `/teleport` command from The First Room.
Use the /teleport
command to go directly to your room to ensure it is running.
_README.md, line 65 at r1 (raw file):_
2. Use the Game On! command `/listmyrooms` from The First Room, to see your list of rooms. Once your room is registered, it will appear in that list. 3. To get to your room, navigate through the network or go directly there by using the `/teleport` command from The First Room. 4. Look at the Bluemix log console to see "A new connection has been made to the room"
Remove #4 here, or replace with, "[Look at the logs for your service](Link to section in advanced adventures dealing with finding logs in different environments) to see confirmation that a new connection has been made to the room"
[README.md, line 71 at r1](https://reviewable.io:443/reviews/gameontext/gameon-room-java/25#-KTQ5XUJp5ZT6zMymBUZ:-KTQ5XUJp5ZT6zMymBU:b-p4i524) (raw file):_
Suggested activities: * Make it more resilient -- add additional instances using the autoscaling add-on: https://console.ng.bluemix.net/catalog/services/auto-scaling * Consider how to allow chat messages to propagate between independent instances using a shared datastore or cache, or an event bus, or...
- Link to other advanced adventures in the book.
Comments from Reviewable
Reviewed 1 of 1 files at r1. Review status: all files reviewed at latest revision, 10 unresolved discussions.
Comments from Reviewable
Review status: all files reviewed at latest revision, 10 unresolved discussions.
_README.md, line 65 at r1 (raw file):_
Will remove for now.
Comments from Reviewable
Review status: 0 of 1 files reviewed at latest revision, 10 unresolved discussions.
_README.md, line 47 at r1 (raw file):_
Done.
README.md, line 50 at r1 (raw file):
Done.
README.md, line 59 at r1 (raw file):
Done.
_README.md, line 60 at r1 (raw file):_
Done.
README.md, line 62 at r1 (raw file):
Done.
_README.md, line 63 at r1 (raw file):_
Done.
README.md, line 64 at r1 (raw file):
Done.
_README.md, line 65 at r1 (raw file):_
Done.
README.md, line 71 at r1 (raw file):
Done.
Comments from Reviewable
Review status: 0 of 1 files reviewed at latest revision, 10 unresolved discussions.
README.md, line 44 at r1 (raw file):
Done.
Comments from Reviewable
Reviewed 1 of 1 files at r2. Review status: all files reviewed at latest revision, all discussions resolved.
Comments from Reviewable
Reorder walkthrough steps to have: Intro General prereqs Build local Deploy (with link to Bluemix or Docker) Register room Find room in Game Deploy to Bluemix Deploy to Docker
Fixes #21
This change is