gameontext / sample-room-java

Walkthrough for creating a room in java for Game On!
https://gameontext.org
Apache License 2.0
20 stars 105 forks source link

CDI injection issues, ENV var usage, Travis for PR #43

Closed ebullient closed 7 years ago

ebullient commented 7 years ago

add beans.xml revise constant lookup/declaration for room id to allow for environment variable publish application into apps dir (not dropins)

change dependencies in pom.xml create travis build to verify tests for new PRs


This change is Reviewable

BarDweller commented 7 years ago

Reviewed 19 of 19 files at r1. Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

BarDweller commented 7 years ago
:lgtm:

Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

ilanpillemer commented 7 years ago

src/main/liberty/config/server.xml, line 43 at r1 (raw file):

    <!-- Environment specific config. 
         Set TARGET=production as env var to include production-config.xml, e.g. -->
    <include location="${env.TARGET}-config.xml" optional="true"/>

I assume this is a liberty specific file?


Comments from Reviewable

ilanpillemer commented 7 years ago
:lgtm:

Comments from Reviewable

ebullient commented 7 years ago

Review status: 17 of 19 files reviewed at latest revision, 1 unresolved discussion.


src/main/liberty/config/server.xml, line 43 at r1 (raw file):

Previously, ilanpillemer (Ilan Pillemer) wrote… > I assume this is a liberty specific file?

Yep.


Comments from Reviewable

ebullient commented 7 years ago

Reviewed 2 of 2 files at r2. Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

ebullient commented 7 years ago

Reviewed 1 of 1 files at r3. Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

ebullient commented 7 years ago

Reviewed 1 of 1 files at r4. Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable