search

gameontext / sample-room-java

Walkthrough for creating a room in java for Game On!
https://gameontext.org
Apache License 2.0
20 stars 105 forks source link

Add open tracing #59

Closed jjvilleg closed 5 years ago

jjvilleg commented 6 years ago

This change is Reviewable

codecov-io commented 6 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@994e801). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #59   +/-   ##
=========================================
  Coverage          ?   68.24%           
  Complexity        ?       90           
=========================================
  Files             ?        9           
  Lines             ?      337           
  Branches          ?       30           
=========================================
  Hits              ?      230           
  Misses            ?       86           
  Partials          ?       21
Impacted Files Coverage Δ Complexity Δ
...a/org/gameontext/sample/protocol/RoomEndpoint.java 0% <ø> (ø) 0 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 994e801...7bc9dde. Read the comment docs.

BarDweller commented 5 years ago

Thank you for the pull request, GameOn has decided to use Istio/Jaeger rather than Zipkin for it's trace flows as we continue to migrate to K8S deployments. Although this PR is interesting as an example of mp tracing, it would conflict with our future direction, so sadly we must decline to merge it at this time.