gameprof / CreatureTrainer-Distribution

The distribution code for the CreatureTrainer Project
0 stars 5 forks source link

Fainted team creature can still apply damage. #1

Closed ghost closed 9 years ago

ghost commented 9 years ago

A team creature can still apply damage even if it has fainted. This is evident when a team creature's raw damage [DMG] is greater than the enemy creature's Current Health [CH], and an attack is issued without switching to another team creature immediately after fainting (before the enemy creature can rest).

I am unable to test whether or not I can defeat a fresh enemy Creature Type [cType] using a fainted Pokemon because their HRI is either greater than my Attack Base [AB] or the type balance is against me.

Example situation (shown in comment below).

Lilisys commented 9 years ago

Can you send us a screenshot of this? I can't fully understand the issue because when I run it, even if my creature is close to fainting, it attacks first, then faints, which means its attack and damage get resolved before it's health reaches zero.

ghost commented 9 years ago

Here's the error.

Lilisys commented 9 years ago

I see What a hacker Ibex Thanks for reporting this, we'll do our best to resolve this as quickly as possible!

Lilisys commented 9 years ago

Wait, what version of the code are you working with? Like when did you download it?

gameprof commented 9 years ago

Yep, I've fixed it already:


ERROR: INVALID MOVE

You lost your turn.

Enemy Wolverine attacks Your Guanaco with Funk for 4 damage.

Your Guanaco faints!

--------------------------------------------------------------------------------

| Tuatara 18/18 | *Guanaco 0/12 | Vaquita 16/16 | Xenops 13/13 |

--------------------------------------------------------------------------------

You must swap to another creature!

Trainer, make your move. (a-Attack, s#-Swap to slot #): a


Your Guanaco can't attack because it has fainted!

Enemy Wolverine rests and regains 6 health.

--------------------------------------------------------------------------------

| Tuatara 18/18 | *Guanaco 0/12 | Vaquita 16/16 | Xenops 13/13 |

--------------------------------------------------------------------------------

You must swap to another creature!

Trainer, make your move. (a-Attack, s#-Swap to slot #): a


Your Guanaco can't attack because it has fainted!

Enemy Wolverine rests and regains 6 health.

--------------------------------------------------------------------------------

| Tuatara 18/18 | *Guanaco 0/12 | Vaquita 16/16 | Xenops 13/13 |

--------------------------------------------------------------------------------

You must swap to another creature!

Trainer, make your move. (a-Attack, s#-Swap to slot #):

———————————————— Jeremy Gibson Game Designer / Professor gameprof@umich.edu (434) 321-8624

On Thu, Nov 20, 2014 at 2:10 PM, Jessica Wu notifications@github.com wrote:

I see What a hacker Ibex Thanks for reporting this, we'll do our best to resolve this as quickly as possible!

— Reply to this email directly or view it on GitHub https://github.com/gameprof/CreatureTrainer-Distribution/issues/1#issuecomment-63861819 .

ghost commented 9 years ago

Ah, I see. I was using the wrong (outdated) repo. Updated to the current distrib repo. Thank you!