search

gameprogcpp / code

Game Programming in C++ Code
Other
1.03k stars 355 forks source link

Chapter 6 - Phong.frag, missing clamp call #36

Open ghost opened 4 years ago

ghost commented 4 years ago

When discussing the Phong.fragshader the book mentions using clamp to limit the Phong RGB components to the 0.0-1.0 range.

The actual clamp call seems to be missing from the shader code, however: https://github.com/gameprogcpp/code/blob/master/Chapter06/Shaders/Phong.frag

Adding this, the visual result is markedly different:

 Phong = clamp(Phong, 0.0, 1.0);
chalonverse commented 4 years ago

Good catch, I actually don't remember whether that's intentional or if it was a mistake!