search

gamerson / evp-portlet-upgrade-webhook

0 stars 4 forks source link

[lugbot] Upgrade workspace plugin version to 3.4.8 #31

Closed lugbot-test closed 3 years ago

lugbot-test commented 3 years ago

Lugbot has created this PR to upgrade workspace plugin version to latest.

merge advice

A new version of Liferay Workspace Gradle plugin is available. This change updates the gradle build to use this new version. Sometimes additional changes are necessasry to take full advantage of the new features in this new plugin version. Please consult the plugin’s https://github.com/liferay/liferay-portal/blob/master/modules/sdk/gradle-plugins-workspace/README.markdown and https://github.com/liferay/liferay-portal/blob/master/modules/sdk/gradle-plugins-workspace/CHANGELOG.markdown to see additional information related to this new version.

:information_source: The upgrades provided in this PR will not be tried again until the branch webhookTest is deleted.

lugbot-test commented 3 years ago

Found 0 Issues for Category 'BugPrevention'

lugbot-test commented 3 years ago

Found 36 Issues for Category 'Performance'

JSPDefineObjectsCheck, click here for documentation

Issues - Use 'liferay-theme:defineObjects' or rename var: [/evp_util.jspf](https://github.com/gamerson/evp-portlet-upgrade-webhook/blob/lugbot_upgrade-workspace-version_UpgradeWorkspacePluginVersion/liferay-workspace/modules/evp/evp-portlet/src/main/webapp/WEB-INF/jsp/util/evp_util.jspf#L266) - Use 'liferay-theme:defineObjects' or rename var: [/evp_validator.jspf](https://github.com/gamerson/evp-portlet-upgrade-webhook/blob/lugbot_upgrade-workspace-version_UpgradeWorkspacePluginVersion/liferay-workspace/modules/evp/evp-portlet/src/main/webapp/WEB-INF/jsp/util/evp_validator.jspf#L122) - Use 'liferay-theme:defineObjects' or rename var: [/evp_validator.jspf](https://github.com/gamerson/evp-portlet-upgrade-webhook/blob/lugbot_upgrade-workspace-version_UpgradeWorkspacePluginVersion/liferay-workspace/modules/evp/evp-portlet/src/main/webapp/WEB-INF/jsp/util/evp_validator.jspf#L160) - Use 'portlet:defineObjects' or rename var: [/evp_validator.jspf](https://github.com/gamerson/evp-portlet-upgrade-webhook/blob/lugbot_upgrade-workspace-version_UpgradeWorkspacePluginVersion/liferay-workspace/modules/evp/evp-portlet/src/main/webapp/WEB-INF/jsp/util/evp_validator.jspf#L282)

UnprocessedExceptionCheck

Issues - Unprocessed exception 'e', see LPS-36174: [/EVPWorkflowUtil.java](https://github.com/gamerson/evp-portlet-upgrade-webhook/blob/lugbot_upgrade-workspace-version_UpgradeWorkspacePluginVersion/liferay-workspace/modules/evp/evp-portlet/src/main/java/com/liferay/evp/util/EVPWorkflowUtil.java#L212)

UnusedVariableCheck

Issues - Variable 'guestSiteGroup' is unused: [/UpgradeUser.java](https://github.com/gamerson/evp-portlet-upgrade-webhook/blob/lugbot_upgrade-workspace-version_UpgradeWorkspacePluginVersion/liferay-workspace/modules/evp/evp-portlet/src/main/java/com/liferay/evp/hook/upgrade/v1_4_0/UpgradeUser.java#L222)

ValidatorEqualsCheck, click here for documentation

Issues - Use Objects.equals(Object, Object) instead of Validator.equals(Object, Object): [/EVPFilter.java](https://github.com/gamerson/evp-portlet-upgrade-webhook/blob/lugbot_upgrade-workspace-version_UpgradeWorkspacePluginVersion/liferay-workspace/modules/evp/evp-portlet/src/main/java/com/liferay/evp/hook/filter/EVPFilter.java#L50) - Use Objects.equals(Object, Object) instead of Validator.equals(Object, Object): [/EVPFilter.java](https://github.com/gamerson/evp-portlet-upgrade-webhook/blob/lugbot_upgrade-workspace-version_UpgradeWorkspacePluginVersion/liferay-workspace/modules/evp/evp-portlet/src/main/java/com/liferay/evp/hook/filter/EVPFilter.java#L51) - Use Objects.equals(Object, Object) instead of Validator.equals(Object, Object): [/EVPServletContextListener.java](https://github.com/gamerson/evp-portlet-upgrade-webhook/blob/lugbot_upgrade-workspace-version_UpgradeWorkspacePluginVersion/liferay-workspace/modules/evp/evp-portlet/src/main/java/com/liferay/evp/servlet/EVPServletContextListener.java#L170) - Use Objects.equals(Object, Object) instead of Validator.equals(Object, Object): [/EVPServletContextListener.java](https://github.com/gamerson/evp-portlet-upgrade-webhook/blob/lugbot_upgrade-workspace-version_UpgradeWorkspacePluginVersion/liferay-workspace/modules/evp/evp-portlet/src/main/java/com/liferay/evp/servlet/EVPServletContextListener.java#L175) - Use Objects.equals(Object, Object) instead of Validator.equals(Object, Object): [/EVPPortalUtil.java](https://github.com/gamerson/evp-portlet-upgrade-webhook/blob/lugbot_upgrade-workspace-version_UpgradeWorkspacePluginVersion/liferay-workspace/modules/evp/evp-portlet/src/main/java/com/liferay/evp/util/EVPPortalUtil.java#L78) - Use Objects.equals(Object, Object) instead of Validator.equals(Object, Object): [/grant_requests_controller.jsp](https://github.com/gamerson/evp-portlet-upgrade-webhook/blob/lugbot_upgrade-workspace-version_UpgradeWorkspacePluginVersion/liferay-workspace/modules/evp/evp-portlet/src/main/webapp/WEB-INF/jsp/evp/controllers/grant_requests_controller.jsp#L65) - Use Objects.equals(Object, Object) instead of Validator.equals(Object, Object): [/grant_requests_controller.jsp](https://github.com/gamerson/evp-portlet-upgrade-webhook/blob/lugbot_upgrade-workspace-version_UpgradeWorkspacePluginVersion/liferay-workspace/modules/evp/evp-portlet/src/main/webapp/WEB-INF/jsp/evp/controllers/grant_requests_controller.jsp#L434) - Use Objects.equals(Object, Object) instead of Validator.equals(Object, Object): [/reviewer_dashboard_controller.jsp](https://github.com/gamerson/evp-portlet-upgrade-webhook/blob/lugbot_upgrade-workspace-version_UpgradeWorkspacePluginVersion/liferay-workspace/modules/evp/evp-portlet/src/main/webapp/WEB-INF/jsp/evp/controllers/reviewer_dashboard_controller.jsp#L189) - Use Objects.equals(Object, Object) instead of Validator.equals(Object, Object): [/service_requests_controller.jsp](https://github.com/gamerson/evp-portlet-upgrade-webhook/blob/lugbot_upgrade-workspace-version_UpgradeWorkspacePluginVersion/liferay-workspace/modules/evp/evp-portlet/src/main/webapp/WEB-INF/jsp/evp/controllers/service_requests_controller.jsp#L62) - Use Objects.equals(Object, Object) instead of Validator.equals(Object, Object): [/service_requests_controller.jsp](https://github.com/gamerson/evp-portlet-upgrade-webhook/blob/lugbot_upgrade-workspace-version_UpgradeWorkspacePluginVersion/liferay-workspace/modules/evp/evp-portlet/src/main/webapp/WEB-INF/jsp/evp/controllers/service_requests_controller.jsp#L572) - Use Objects.equals(Object, Object) instead of Validator.equals(Object, Object): [/evp_portal_util.jspf](https://github.com/gamerson/evp-portlet-upgrade-webhook/blob/lugbot_upgrade-workspace-version_UpgradeWorkspacePluginVersion/liferay-workspace/modules/evp/evp-portlet/src/main/webapp/WEB-INF/jsp/util/evp_portal_util.jspf#L61) - Use Objects.equals(Object, Object) instead of Validator.equals(Object, Object): [/evp_util.jspf](https://github.com/gamerson/evp-portlet-upgrade-webhook/blob/lugbot_upgrade-workspace-version_UpgradeWorkspacePluginVersion/liferay-workspace/modules/evp/evp-portlet/src/main/webapp/WEB-INF/jsp/util/evp_util.jspf#L206) - Use Objects.equals(Object, Object) instead of Validator.equals(Object, Object): [/evp_workflow_util.jspf](https://github.com/gamerson/evp-portlet-upgrade-webhook/blob/lugbot_upgrade-workspace-version_UpgradeWorkspacePluginVersion/liferay-workspace/modules/evp/evp-portlet/src/main/webapp/WEB-INF/jsp/util/evp_workflow_util.jspf#L61) - Use Objects.equals(Object, Object) instead of Validator.equals(Object, Object): [/evp_workflow_util.jspf](https://github.com/gamerson/evp-portlet-upgrade-webhook/blob/lugbot_upgrade-workspace-version_UpgradeWorkspacePluginVersion/liferay-workspace/modules/evp/evp-portlet/src/main/webapp/WEB-INF/jsp/util/evp_workflow_util.jspf#L75)

VariableDeclarationAsUsedCheck

Issues - No need to declare variable 'userId'. Pass the method call directly as parameter on line '40'.: [/LoginPostAction.java](https://github.com/gamerson/evp-portlet-upgrade-webhook/blob/lugbot_upgrade-workspace-version_UpgradeWorkspacePluginVersion/liferay-workspace/modules/evp/evp-portlet/src/main/java/com/liferay/evp/hook/events/LoginPostAction.java#L38) - No need to declare variable 'grantTypeAmountFieldName'. Pass the method call directly as parameter on line '517'.: [/UpgradeEVPGrantRequest.java](https://github.com/gamerson/evp-portlet-upgrade-webhook/blob/lugbot_upgrade-workspace-version_UpgradeWorkspacePluginVersion/liferay-workspace/modules/evp/evp-portlet/src/main/java/com/liferay/evp/hook/upgrade/v1_1_0/UpgradeEVPGrantRequest.java#L514) - No need to declare variable 'validRequestOrganizationIds'. Pass the method call directly as parameter on line '78'.: [/UpgradeEVPRequestOrganization.java](https://github.com/gamerson/evp-portlet-upgrade-webhook/blob/lugbot_upgrade-workspace-version_UpgradeWorkspacePluginVersion/liferay-workspace/modules/evp/evp-portlet/src/main/java/com/liferay/evp/hook/upgrade/v1_1_0/UpgradeEVPRequestOrganization.java#L75) - For better performance, the variable declaration for 'evpRequestClassName' should come after the 'continue' statement on line '150': [/UpgradeMBMessage.java](https://github.com/gamerson/evp-portlet-upgrade-webhook/blob/lugbot_upgrade-workspace-version_UpgradeWorkspacePluginVersion/liferay-workspace/modules/evp/evp-portlet/src/main/java/com/liferay/evp/hook/upgrade/v1_1_0/UpgradeMBMessage.java#L140) - For better performance, the variable declaration for 'evpRequestClassPK' should come after the 'continue' statement on line '150': [/UpgradeMBMessage.java](https://github.com/gamerson/evp-portlet-upgrade-webhook/blob/lugbot_upgrade-workspace-version_UpgradeWorkspacePluginVersion/liferay-workspace/modules/evp/evp-portlet/src/main/java/com/liferay/evp/hook/upgrade/v1_1_0/UpgradeMBMessage.java#L141) - No need to declare variable 'validRequestIds'. Pass the method call directly as parameter on line '86'.: [/UpgradeUser.java](https://github.com/gamerson/evp-portlet-upgrade-webhook/blob/lugbot_upgrade-workspace-version_UpgradeWorkspacePluginVersion/liferay-workspace/modules/evp/evp-portlet/src/main/java/com/liferay/evp/hook/upgrade/v1_1_0/UpgradeUser.java#L84) - No need to declare variable 'grantTypeAmountFieldName'. Pass the method call directly as parameter on line '478'.: [/UpgradeEVPGrantRequest.java](https://github.com/gamerson/evp-portlet-upgrade-webhook/blob/lugbot_upgrade-workspace-version_UpgradeWorkspacePluginVersion/liferay-workspace/modules/evp/evp-portlet/src/main/java/com/liferay/evp/hook/upgrade/v1_4_0/UpgradeEVPGrantRequest.java#L475) - No need to declare variable 'validRequestOrganizationIds'. Pass the method call directly as parameter on line '82'.: [/UpgradeEVPRequestOrganization.java](https://github.com/gamerson/evp-portlet-upgrade-webhook/blob/lugbot_upgrade-workspace-version_UpgradeWorkspacePluginVersion/liferay-workspace/modules/evp/evp-portlet/src/main/java/com/liferay/evp/hook/upgrade/v1_4_0/UpgradeEVPRequestOrganization.java#L79) - For better performance, the variable declaration for 'createDate' should be moved inside the if-statement on line '232': [/UpgradeEVPRequestOrganization.java](https://github.com/gamerson/evp-portlet-upgrade-webhook/blob/lugbot_upgrade-workspace-version_UpgradeWorkspacePluginVersion/liferay-workspace/modules/evp/evp-portlet/src/main/java/com/liferay/evp/hook/upgrade/v1_4_0/UpgradeEVPRequestOrganization.java#L193) - For better performance, the variable declaration for 'taxIdentificationNumber' should be moved inside the if-statement on line '232': [/UpgradeEVPRequestOrganization.java](https://github.com/gamerson/evp-portlet-upgrade-webhook/blob/lugbot_upgrade-workspace-version_UpgradeWorkspacePluginVersion/liferay-workspace/modules/evp/evp-portlet/src/main/java/com/liferay/evp/hook/upgrade/v1_4_0/UpgradeEVPRequestOrganization.java#L224) - For better performance, the variable declaration for 'evpRequestClassName' should come after the 'continue' statement on line '150': [/UpgradeMBMessage.java](https://github.com/gamerson/evp-portlet-upgrade-webhook/blob/lugbot_upgrade-workspace-version_UpgradeWorkspacePluginVersion/liferay-workspace/modules/evp/evp-portlet/src/main/java/com/liferay/evp/hook/upgrade/v1_4_0/UpgradeMBMessage.java#L140) - For better performance, the variable declaration for 'evpRequestClassPK' should come after the 'continue' statement on line '150': [/UpgradeMBMessage.java](https://github.com/gamerson/evp-portlet-upgrade-webhook/blob/lugbot_upgrade-workspace-version_UpgradeWorkspacePluginVersion/liferay-workspace/modules/evp/evp-portlet/src/main/java/com/liferay/evp/hook/upgrade/v1_4_0/UpgradeMBMessage.java#L141) - No need to declare variable 'validRequestIds'. Pass the method call directly as parameter on line '144'.: [/UpgradeUser.java](https://github.com/gamerson/evp-portlet-upgrade-webhook/blob/lugbot_upgrade-workspace-version_UpgradeWorkspacePluginVersion/liferay-workspace/modules/evp/evp-portlet/src/main/java/com/liferay/evp/hook/upgrade/v1_4_0/UpgradeUser.java#L142) - No need to declare variable 'servletContextName'. Pass the method call directly as parameter on line '189'.: [/EVPServletContextListener.java](https://github.com/gamerson/evp-portlet-upgrade-webhook/blob/lugbot_upgrade-workspace-version_UpgradeWorkspacePluginVersion/liferay-workspace/modules/evp/evp-portlet/src/main/java/com/liferay/evp/servlet/EVPServletContextListener.java#L186) - No need to declare variable 'bytes'. Pass the method call directly as parameter on line '92'.: [/EVPWorkflowUtil.java](https://github.com/gamerson/evp-portlet-upgrade-webhook/blob/lugbot_upgrade-workspace-version_UpgradeWorkspacePluginVersion/liferay-workspace/modules/evp/evp-portlet/src/main/java/com/liferay/evp/util/EVPWorkflowUtil.java#L88) - For better performance, the variable declaration for 'ownerRole' should come after the 'return' statement on line '238': [/EVPWorkflowUtil.java](https://github.com/gamerson/evp-portlet-upgrade-webhook/blob/lugbot_upgrade-workspace-version_UpgradeWorkspacePluginVersion/liferay-workspace/modules/evp/evp-portlet/src/main/java/com/liferay/evp/util/EVPWorkflowUtil.java#L230)