gamerson / liferay-blade-cli

Apache License 2.0
3 stars 0 forks source link

[migrator] com.liferay.portlet.calendar.model.CalEvent is removed in 7.x #217

Open AndyWu2015 opened 7 years ago

AndyWu2015 commented 7 years ago

com.liferay.portlet.calendar.model.CalEvent will be fixed into com.liferay.portal.kernel.portlet.calendar.model.CalEvent and this also can't be found in 7.0 portal-kernel or calander related modules. And this is not documented in BREAKING_CHANGES.markdown , so we need to figure out how to help user fixing this.

Also , in RenamePortalKernelImports.java , we have some logic problem : "com.liferay.portlet" contains "com.liferay.portlet.admin.util" , so if "com.liferay.portlet.admin.util.Foo" exists in java code , and we will match the first string not the accurate second one.

gamerson commented 7 years ago

Hey Andy, we need to try to address this in Liferay IDE M3

On Mon, Jan 23, 2017 at 10:00 PM, Andy Wu notifications@github.com wrote:

com.liferay.portlet.calendar.model.CalEvent will be fixed into com.liferay.portal.kernel.portlet.calendar.model.CalEvent and this also can't be found in 7.0 portal-kernel or calander related modules. And this is not documented in BREAKING_CHANGES.markdown , so we need to figure out how to help user fix this.

Also , in RenamePortalKernelImports.java , we have some logic problem : "com.liferay.portlet" contains "com.liferay.portlet.admin.util" , so if "com.liferay.portlet.admin.util.Foo" exist in java code , and we will match the first string not the accurate second one.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/gamerson/liferay-blade-cli/issues/217, or mute the thread https://github.com/notifications/unsubscribe-auth/AAkVFaGQkv6Eusf3llJl6K8g5sWgfwjjks5rVXdBgaJpZM4Lr1t- .

-- Greg Amerson Liferay Developer Tools Liferay, Inc. www.liferay.com

AndyWu2015 commented 7 years ago

ok