search

gamerson / liferay-jsp-spy

Apache License 2.0
13 stars 5 forks source link

research adding support for jspf files #2

Open gamerson opened 5 years ago

protoEvangelion commented 5 years ago

I was excited to use jsp-spy because I was trying to debug Liferay's top_head.jsp, however, it includes quite a few jspf fragments.

It would be helpful if there was a way to view the demarcation of jspfs in Chrome dev tools as well to see where assets start & stop.

This tool is looking nice so far! Great job :)

gamerson commented 5 years ago

JSPF files will be tough because the are included by a <%@ include %> instruction that doesn't include a JSP dispatch (which is how the JSP spy currently detects JSPs). We would need to augment the JSP compiler to include markup before/after those include instructions.

On Mon, Mar 18, 2019 at 11:58 AM Ryan Garant notifications@github.com wrote:

I was excited to use jsp-spy because I was trying to debug Liferay's top_head.jsp, however, it includes quite a few jspf fragments.

It would be helpful if there was a way to view the demarcation of jspfs in Chrome dev tools as well to see where assets start & stop.

This tool is looking nice so far! Great job :)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/gamerson/liferay-jsp-spy/issues/2#issuecomment-474005752, or mute the thread https://github.com/notifications/unsubscribe-auth/AAkVFaoKsEptIxJnFgkT6Crtqoi-7xdRks5vX8WtgaJpZM4bukK_ .

-- Greg Amerson Liferay Developer Tools Liferay, Inc. www.liferay.com

protoEvangelion commented 5 years ago

Might be crazy, but could we do a regex for <%@ include.. and wrap it with a html comment?