search

gamerson / liferay-jsp-spy

Apache License 2.0
13 stars 5 forks source link

[Idea] Use data- attributes instead of HTML comments #4

Open balcsida opened 5 years ago

balcsida commented 5 years ago

Instead of relying on HTML comments, I think adding a data attribute (e.g. data-jspspy="somethingsomething") to the correct HTML element can result in much more accurate DOM results.

What do you think, @gamerson?

gamerson commented 5 years ago

Hey @balcsida

For taglib calls like <liferay-ui:search-container> or anything that renders an html tag (like div or span), or maybe like <liferay-ui:icon> we could put in a data-jspspy for sure and tht would be much more exact. For just any jsp content we could not since there is no element in this case.

So yeah we should research to see if our jsp-spy-servlet-filter if we can correctly identify a jsp taglib invocation where it is rendering a startTag