search

games-on-whales / wolf

Stream virtual desktops and games running in Docker
https://games-on-whales.github.io/wolf/stable/
MIT License
292 stars 20 forks source link

Fix compilation on GCC 13 #26

Closed cupown closed 1 year ago

cupown commented 1 year ago

This patch fix compilation with GCC 13.

Wolf doesn't seem to work on my machine, I'm getting some HTTPS error during request at /launch error code: 125 - Operation canceled while launching an app. But at least this patch fix compilation.

ABeltramo commented 1 year ago

Thanks for taking the time to contribute and welcome 👋

Can you add GCC 13 to the CI tests here? I guess you'll have to bump up Ubuntu to 23.04 in order to get the package.

Would you like to open up an issue about your problem with some additional logs?

cupown commented 1 year ago

I am sorry, but I do not want to take the time to mess with CI. It can quickly be time-consuming. You can push to my branch if you want to add CI change to this PR.

In the same way, I don't think I want to try to troubleshoot my issue, I have been burned too much with sunshine. I do not have enough energy left to spend time on streaming desktop/games, I will let projects mature a bit before trying again.

At least wolf seem to be more on track with what I want. Sunshine seem just like a husk of itself. The new maintainer does not seem to know the codebase and does not contribute to it. It seem like this project was just taken over for some fame or monetary reason. One example is the addition of a CLA, that turn off a lot of FOSS contributors, the only advantage is now the new maintainer can use contributions if they make a proprietary project based on sunshine. Also, linux seem like forgotten in the fork, there is a single contributor that help with it. Wolf seem more linux focused.

So, I hope wolf will continue to evolve to fulfill my need, but I do not have the will to help with that currently. I just wanted to push a small fix that might be one less step for the next person that want to play with wolf.