search

games50 / pong

Atari's 1972 classic, implemented in Lua with LÖVE
835 stars 1.13k forks source link

setColour in displayFPS() does not work right #70

Open tkzv opened 3 years ago

tkzv commented 3 years ago

The FPS counter is not visible in pong-6, pong-7, pong-8, pong-11 and pong-12.

The line love.graphics.setColor(0, 255/255, 0, 255/255) in function displayFPS() in main.lua is wrong. pong-10 and pong-11 have the correct line love.graphics.setColor(0, 255, 0, 255), the colours are in range 0-255, not 0.0-1.0.

Observed in Ubuntu Linux 18.04, Love 0.9.1-4.

Blauelf commented 2 years ago

Version 0.9.1-4 is pretty old.

When the course started, version 0.10.2 was the current version, so lectures use values 0-255.

Since LÖVE has changed since then, in July 2020 the sources got updated to work with a newer 11.x version of LÖVE (and matching push.lua), which expect 0.0-1.0 instead.