games50 / pong

Atari's 1972 classic, implemented in Lua with LÖVE
835 stars 1.13k forks source link

SetColor not working as demonstrated #73

Open Schmel924 opened 2 years ago

Schmel924 commented 2 years ago

In lecture during presentation of pong-6 (fps update), new function was introduced: love.graphics.setColor(0, 255/255, 0, 255/255) In love2d this "new" color should persist between frames (or calls to love.draw function) But in this example it seems each frame defaults back to white color, without explicitly calling love.graphics.setColor

I highly suspect push library is an actual reason behind this, especially line love.graphics.setColor(white, white, white) which is called during "push:finish" function, which is actually called with push:apply('end')

Ashish-sarmah commented 1 year ago

@Schmel924 You have suspected it very well, as I put the displayfps() function outside the push:apply('start') and push:apply('end') boundaries and the color didn't changed to white(default) it remained same as in displayfps() function. Also to be more specific I just commented the line in the push:finish() function where the color was set to white and the displayfps() color persisted. So you can just comment out the line in push.lua file where color is changed to white and your problem is solved

Ashish-sarmah commented 1 year ago

Please assign me , I will do it.