games647 / FastLogin

Checks if a minecraft player has a valid paid account. If so, they can skip offline authentication automatically. (premium auto login)
https://www.spigotmc.org/resources/fastlogin.14153
MIT License
506 stars 123 forks source link

Users doesnt autologin with viaversion in 1.13+ #338

Open Fabri4K opened 4 years ago

Fabri4K commented 4 years ago

What behaviour is observed:

When i try to use /premium it works and it always autlogins me. The problem is when you use viaversion. Idk if i should report this here or in viaversion but With a spigot 1.8.8 server and viaversion, when players try to join in 1.13+ even if they type /premium the plugin doesnt autologin them. They have to use /login {password} (manually login). Also i have to mention that my fastlogin is working using bungeecord. This is my authlobby.

What behaviour is expected:

The plugin is supposed to autologin the players and it doesnt autlogin them in 1.13+

Steps/models to reproduce:

1) Use viaversion on a spigot 1.8.8 server. With bungeecord 2) Join with a minecraft version 1.13+ 3) You will see that even if you type /premium and then relog it still ask you to use /login password

Screenshots (if applicable)

https://imgur.com/a/eeL1j0a (the message is in spanish but it says "hello, please login using /login password")

Plugin list:

Bungeecord: Skinsrestorer, Advancedban, BuycraftX, FastLogin, Luckperms-Bungee, ServerListPlus, StaffChat Authlobby: (Im gonna send a screenshot because there are so many xD) https://imgur.com/a/uuPRP41

Environment description

Bungeecord network, the plugin is in the bungeecord and in the authlobby. Bungeecord version: #1495 AuthLobby version: 1.8.8 spigot

Plugin version or build number (don't write latest):

1.10

Server Log:

No errors

Configuration:

Bungeecord: https://pastebin.com/mG10xg2w AuthLobby: https://pastebin.com/y3gkAtSn

games647 commented 4 years ago

Please update to dev build.

EDIT: It might be already fixed.

Maxetto commented 4 years ago

I managed to fix this by disabling useAsyncTasks in AuthMe as I found it also happened with session logins. Related to #310

Fabri4K commented 4 years ago

I managed to fix this by disabling useAsyncTasks in AuthMe as I found it also happened with session logins. Related to #310

hello, i disabled useAsyncTasks, i updated viaversion and i tried to use fastlogin dev build but when i use the ultimate dev build of fastlogin the /premium and autologin doesnt even works on 1.8.8 and the useAsyncTasks didnt worked so i still have the same problem

games647 commented 4 years ago

Which viaversion build do you use?

Fabri4K commented 4 years ago

Which viaversion build do you use?

normally i use viaversion 2.2.3 but when i tried updated it didnt worked

alexsobiek commented 4 years ago

I too am having this exact same error. I have the latest dev build as well as the most recent ViaVersion. Clients above 1.12.2 are required to login or register even if they are premium.

I have disabled useAsyncTasks and tinkered with a lot of other AuthMe settings.

alexsobiek commented 4 years ago

So I'm running waterfall with two paper servers, one of which is purely for authentication and the other is the main server. My situation involves people logging in and being sent to the auth server first, if their premium they are auto logged in or registered and sent to the main server right away, or if they are non-premium they have to login/register first. I had the same issue with clients 1.13+ having to login/register regardless of premium or not.

I started by disabling ViaVerison on my auth server first and 1.12.2 clients worked perfectly fine with FastLogin. I then found out ViaVersion can be installed on waterfall/bungee instead of on the Minecraft servers themselves so I opted for that instead. Set all of that up as well as disabled useAsyncTasks and it now works.

This leads me to believe the issue originates with ViaVersion installed on paper/spigot. I know the devs of FastLogin have nothing to do with ViaVersion so I'm not sure what can be done about it, but I have found a working solution.