search

games647 / FastLogin

Checks if a minecraft player has a valid paid account. If so, they can skip offline authentication automatically. (premium auto login)
https://www.spigotmc.org/resources/fastlogin.14153
MIT License
503 stars 121 forks source link

Users aren't registered when using NPCs #355

Open bobhenl opened 4 years ago

bobhenl commented 4 years ago

What behaviour is observed:

Players execute /premium 2* and then log again... and they still have to use password.

What behaviour is expected:

Add players to premium players list instantly when they confirm that they wanna use premium....

Steps/models to reproduce:

I'm just running Auth server, where players can click on NPC to set their premium or use /premium and then Bungee (Waterfall). Players click twice on NPC and it says that they are added to premium list... but they go into portal on Lobby, log again and they still have to use password.... Sometimes help clicking more times on NPC maybe, but not for everyone.

Screenshots (if applicable)

Plugin list:

AdvancedPortals, AuthMe, AuthMeTitle, Captchas, ChatDisable, Citizens, CommandSync, ExploitFixer, FastLogin, HackedCore, HackedServer, HamsterAPI, HidePlugins_Project, HolographicDisplays, HoloInfo, IPWhiteListBukkit, JukeBox, LagAssist, LuckPerms, MyCommand, NoteBlockAPI, ProtocolLib, Vault

Bungee: antibot, antivpn, authmebungee, breport, bungeecommand, bungeetablist, cmib, commandsyncserver, dsgvo, exploitfixer, ezprotector, fastlogin, friends bungee, hackedserver, ipwhitelist, litebans, luckperms, movemenow, mycommand, nuvotifier, serverlistplus, skinsrestorer

Environment description

MySQL

Plugin version or build number (don't write latest):

This server is running Paper version git-Paper-325 (MC: 1.15.2) (Implementing API version 1.15.2-R0.1-SNAPSHOT)

Bungee: Waterfall 346

Server Log:

Hastebin / Gist link of the error, stacktrace or the complete log (if any) There isn't probably anything weird.... but will give, if there is.

Configuration:

Hastebin / Gist link of your config.yml file

Bungee: https://hastebin.com/moyepewice.makefile Auth: https://hastebin.com/tesawukubu.makefile

games647 commented 4 years ago

Where is the plugin version and please post the server log at the time of the premium login.

bobhenl commented 4 years ago

Look at these images please:

https://cdn.discordapp.com/attachments/701453803307663480/717066555006910505/Minecraft__1.15.2_-_Multiplayer_3rd-party_01.06.2020_19_25_46.png -> Image, where player shows how he clicked on NPC and was added to player list (tried click many times)

After login again: https://media.discordapp.net/attachments/701453803307663480/717067174740754492/Minecraft__1.15.2_-_Multiplayer_3rd-party_01.06.2020_19_28_13.png?width=1204&height=677

And again.... https://media.discordapp.net/attachments/701453803307663480/717067163801747507/Minecraft__1.15.2_-_Multiplayer_3rd-party_01.06.2020_19_28_31.png?width=1204&height=677

In log isn't anything when he "is added" to premium list... there's just:

[19:28:05 INFO]: [FastLogin] No on-going login session for player: CraftPlayer{name=MukiCZ} with ID xxxxxx
BTW version: version FastLogin
[19:28:10 INFO]: FastLogin version 1.11-SNAPSHOT-7c125dc
[19:28:10 INFO]: Automatically login premium (paid accounts) player on a offline mode server
[19:28:10 INFO]: Website: https://www.spigotmc.org/resources/fastlogin.14153/fastlogin.bukkit/
[19:28:10 INFO]: Authors: games647 and https://github.com/games647/FastLogin/graphs/contributors

And in bungee console isn't anything from fastlogin...

games647 commented 4 years ago

And in bungee console isn't anything from fastlogin...

There should be at least the message that it sends the force login. Could you please check that?

bobhenl commented 4 years ago

I discovered that it's causing when players are kicked from Auth server into Lobby or teleported with Portal into Lobby... Then they play (go from Lobby) normally on Survival, Semi-Vanilla and when they connect back, they have to use password again and it says that they aren't added in database....

BUT! When players add themselves to premium list and THEN quit and join again on AUTH server, they're added succesfully.

bobhenl commented 4 years ago

Any idea @games647 ?

games647 commented 4 years ago

No on-going login session for player

Is this message always printed or only when the issue occurs?

bobhenl commented 4 years ago

Prints everytime when player with non-active premium login join the auth server.

Btw it would be nice if it adds player to the premium list even if he join another server through bungee and not just when he left Auth server.

bobhenl commented 4 years ago

When I use /premium on Auth and then go to Lobby portal, then relog on Lobby and I have to use password again on Auth.

From Auth

[02:32:10 INFO]: UUID of player Renzotom is 113f29bc-3478-3af0-9a41-61970f9ed4fe
[02:32:10 INFO]: Renzotom[/xxx:48630] logged in with entity id 23 at ([world]-27.861533034401532, 68.0, -21.173826504594622)
[02:32:11 INFO]: [FastLogin] No on-going login session for player: CraftPlayer{name=Renzotom} with ID xxx:48630
[02:32:16 INFO]: [AuthMe] Renzotom logged in!
[02:32:21 INFO]: Renzotom lost connection: Disconnected
[02:32:26 INFO]: UUID of player Renzotom is 113f29bc-3478-3af0-9a41-61970f9ed4fe
[02:32:27 INFO]: Renzotom[/xxx:48808] logged in with entity id 24 at ([world]-27.861533034401532, 68.0, -21.173826504594622)
[02:32:27 INFO]: [FastLogin] No on-going login session for player: CraftPlayer{name=Renzotom} with ID xxx:48808

From Proxy

>.... [02:32:10 INFO] [FastLogin]: Incoming login request for Renzotom from /xxx:54982
>.... [02:32:10 INFO] [FastLogin]: Handling player Renzotom
>.... [02:32:10 INFO]: [Renzotom|/xxx:54982] <-> ServerConnector [Auth] has connected
>.... [02:32:20 INFO]: [Renzotom|/xxx:54982] <-> ServerConnector [Lobby] has connected
>.... [02:32:21 INFO]: [/xxx:54982|Renzotom] <-> DownstreamBridge <-> [Auth] has disconnected
>.... [02:32:25 INFO]: [/xxx:54982|Renzotom] -> UpstreamBridge has disconnected
>.... [02:32:25 INFO]: [/xxx:54982|Renzotom] <-> DownstreamBridge <-> [Lobby] has disconnected
>.... [02:32:26 INFO] [FastLogin]: Incoming login request for Renzotom from /xxx:63081
>.... [02:32:26 INFO] [FastLogin]: Handling player Renzotom
>.... [02:32:26 INFO]: [Renzotom|/xxx:63081] <-> ServerConnector [Auth] has connected
>.... [02:32:36 INFO]: [/xxx:63081|Renzotom] <-> DownstreamBridge <-> [Auth] has disconnected

From Lobby, where I logged and then left:

[02:32:22 INFO]: Renzotom[/xxx:42476] logged in with entity id 407 at ([Lobby]64.6110427518272, 32.0, 115.43379465460472)
[02:32:25 INFO]: Renzotom left the game

Please solve it (

bobhenl commented 4 years ago

When relogin on Auth after using /premium -> works when login again, I don't have to use password.

[02:37:22 INFO]: UUID of player Renzotom is 113f29bc-3478-3af0-9a41-61970f9ed4fe
[02:37:22 INFO]: Renzotom[/xxxx:52420] logged in with entity id 27 at ([world]-27.861533034401532, 68.0, -21.173826504594622)
[02:37:23 INFO]: [FastLogin] No on-going login session for player: CraftPlayer{name=Renzotom} with ID xxxx:52420
[02:37:26 INFO]: [AuthMe] Renzotom logged in!
[02:37:30 INFO]: Renzotom lost connection: Disconnected
[02:37:32 INFO]: UUID of player Renzotom is 113f29bc-3478-3af0-9a41-61970f9ed4fe
[02:37:32 INFO]: [FastLogin] Player info LOGIN command for Renzotom from proxy
[02:37:32 INFO]: [FastLogin] Delaying force login until join event fired?: false
[02:37:32 INFO]: Renzotom[/xxxx:52548] logged in with entity id 28 at ([world]-27.861533034401532, 68.0, -21.173826504594622)
[02:37:33 INFO]: [FastLogin] Logging player Renzotom in
[02:37:33 INFO]: [AuthMe] Renzotom logged in!
[02:37:38 INFO]: Renzotom lost connection: Disconnected

Proxy

>.... [02:37:22 INFO] [FastLogin]: Incoming login request for Renzotom from /xxxx:52011
>.... [02:37:22 INFO] [FastLogin]: Handling player Renzotom
>.... [02:37:22 INFO]: [Renzotom|/xxxx:52011] <-> ServerConnector [Auth] has connected
>.... [02:37:30 INFO]: [/xxxx:52011|Renzotom] -> UpstreamBridge has disconnected
>.... [02:37:30 INFO]: [/xxxx:52011|Renzotom] <-> DownstreamBridge <-> [Auth] has disconnected
>.... [02:37:31 INFO] [FastLogin]: Incoming login request for Renzotom from /xxxx:57284
>.... [02:37:31 INFO] [FastLogin]: Handling player Renzotom
>.... [02:37:31 INFO] [FastLogin]: Requesting premium login for registered player: Renzotom
>.... [02:37:32 INFO] [FastLogin]: Overridden UUID from a4e11efc-7feb-4e2a-acb5-4b642438f6a7 to 113f29bc-3478-3af0-9a41-61970f9ed4fe (based of Renzotom) on [/xxxx:57284|Renzotom] <-> InitialHandler
>.... [02:37:32 INFO]: [Renzotom|/xxxx:57284] <-> ServerConnector [Auth] has connected
>.... [02:37:38 INFO]: [Renzotom|/xxxx:57284] <-> ServerConnector [Lobby] has connected
>.... [02:37:38 INFO]: [/xxxx:57284|Renzotom] <-> DownstreamBridge <-> [Auth] has disconnected
bobhenl commented 4 years ago

Btw could this be solved too? I expect it's from FastLogin, when it's in same time. `>.... [16:56:10 INFO] [FastLogin]: Handling player EPGMooky

.... [16:56:10 WARN]: Event PreLoginEvent(cancelled=false, cancelReasonComponents=null, connection=[/xxxxx:52951|EPGMooky] <-> InitialHandler) took 260ms to process!`

bobhenl commented 4 years ago

Btw I created video for you.... https://streamable.com/0dsg4n notice, when I'm teleported to Lobby and then reconnect (relog) I have to log in again... I'm not added to premium list even if it says that I am.... so everytime players log out on another server than Auth he isn't added and has to log again....

At the last seconds of video I showed you what happens if you relog on Auth... It adds you and next time you log in you're normally added.

BTW don't notice it sometimes teleports me automatically to Lobby, because I have set when you're 20 sec after login on Auth it automatically kicks you to Lobby.

bobhenl commented 4 years ago

@games647 please finally fix this issue

games647 commented 4 years ago

Do you have the auth plugin installed on the lobby too? FastLogin is implemented to wait for the confirmation of the auth plugin before accept a premium change.

bobhenl commented 4 years ago

No, it's just on Auth server, because when it was on Lobby it bugged... players have to use password everytime they logged there.... so when players would use /lobby they have to enter password again and again..... Only solution of this was have fastlogin and authme on ALL servers, but this bugged also that they have to login on Lobby.... so we decided to move LOGIN systems just on bungee and just on AUTH.

bobhenl commented 4 years ago

Maybe you could add option to disable accepting... Or couldn't it accept just on bungee side? I need it fix as soon as possible... players complain about it.

bobhenl commented 4 years ago

@games647 any solution?

bobhenl commented 4 years ago

Hey @games647

bobhenl commented 4 years ago

Please @games647 finally make something.

bobhenl commented 4 years ago

@ishland @games647

bobhenl commented 4 years ago

@ishland @games647 still waiting guys...