games647 / FastLogin

Checks if a minecraft player has a valid paid account. If so, they can skip offline authentication automatically. (premium auto login)
https://www.spigotmc.org/resources/fastlogin.14153
MIT License
494 stars 121 forks source link

Economy Integration - Vault? #394

Open TKwSni opened 4 years ago

TKwSni commented 4 years ago

Is your feature request related to a problem? Please describe.

There are plugins that work when you are offline, if you are offline and you are premium, plugins that handle economy cannot get the premium player uuid if you have premium uuid set to true.

Describe the solution you'd like

would it be possible to make inject vault or somehow make fastlogin to handle economy requests using fastlogin uuids?

How to reproduce this problem

Use any economy plugin that isnt essentials, plus quickshop for example.

Create aquickshop store using a premium player, then buy from that store.

there are two scenarios that i have seen:

  1. economy plugin creates a new entry with an offline uuid and pays that uuid
  2. economy plugin pays the premium uuid correctly but if for some reason this player once joined as cracked and then used /premium to fix his uuid, he has two entries in the economy plugin, and quickshop will pay the offline uuid one because it is the first result.
games647 commented 4 years ago

Normally the server should use the UUID of existing players, based on the username cache. Does it only happen with quick shop?

TKwSni commented 4 years ago

it's the only plugin on my server that pays users when they are offline, https://github.com/Ghost-chu/QuickShop-Reremake

but I also had another plugin that fetch uuids of players when they are offline, the problem is as I explained before, if for some reason a premium players got bugged and joined as nopremium (it happened to me many times before) it will generate a player file for that player with cracked uuid and when they are offline, quickshop or any other plugin, will use that offline uuid.

for example in the economy plugin this happens, so quickshop will use the offline uuid instead imagen

openinv also uses the offline uuid if for some reason that playername has 2 uuids.

Vlad0Crystal commented 4 years ago

I had a similar problem too. It just helped what I cleaned.

It took a long time and it took only 20 people to solve the problem. But this is not convenient.