search

games647 / FastLogin

Checks if a minecraft player has a valid paid account. If so, they can skip offline authentication automatically. (premium auto login)
https://www.spigotmc.org/resources/fastlogin.14153
MIT License
506 stars 123 forks source link

Could not check whether Bedrock player's name conflicts a premium Java player's name #982

Open paj1s opened 1 year ago

paj1s commented 1 year ago

What happened?

After update to 1.19.3 i can't join because of this. (well not necessary by the update, i havent tried in a while)

What did you expect?

To join as usual.

Steps to reproduce

I have auto-register and auto-login to no-conflict, allowFloodgateNameConflict was to false but i also tried linked. The floodgate is set to have no prefix and my username has no special characters. It worked with this config so maybe something changed in mojangs api or maybe the account itself? I have the newest everything.

Plugin list

No response

Configuration file

No response

Server log

No response

Plugin version

Newest

Platform

BungeeCord

Relevance

ipozow commented 1 year ago

You forgot to add some details.

This happens with Geyser and Floodgate, and FastLogin Bungee #1192.

It happens with Geyser Bungee 1287, #1286, #1285, #1284, #1272, #1271, and #1270. Basically any Geyser BungeeCord version.

Floodgate versions: #74 and #73.

paj1s commented 1 year ago

And what is the cause of it?

rapofil commented 1 year ago

the same problem

rapofil commented 1 year ago

without fastlogin bedrock players will join. previously this problem was not present and the configs were not modified

Teleriann commented 1 year ago

Yes, same problem here, i have not changed any settings at all, players get this screen: image

and i can see this in my console: image

tried to update fastlogin, geyser, waterfall/bungeecord, floodgate, nothing works

Scoooolzs commented 1 year ago

i have this error too, but i'm not using bungee, only spigot

Smart123s commented 1 year ago

Is the issue still present? Everything works fine on my end today.

ACluco1 commented 1 year ago

is this going to be fixed someday?

Smart123s commented 1 year ago

Did you try with the latest versions of Geyser, FastLogin, Flodgate, ProtocolLib, Ppaer, Bungee, Bedrock game etc. I wasn't able to reproduce the bug when I last tried 3 weeks ago. Could you please recheck @ACluco1 with every plugin on the latest version? If it doesn't work, could you please also try (the rather unsafe) allowFloodgateNameConflict: true in config.yml? It would help me a lot. Thanks.

ACluco1 commented 1 year ago

Im just using Geyser, FastLogin, Floodgate, ProtocolLib, and Purpur (which is a paper fork), everything updated, just single server without bungee, im getting messages that fastlogin could not check whether Bedrock Player name conflicts a premium Java player's name. When i disable fastlogin, bedrock players can join.

Smart123s commented 1 year ago

Does changing allowFloodgateNameConflict to true help?

ACluco1 commented 1 year ago

Does changingallowFloodgateNameConflict to true help?

I somehow cannot find it in the config, it might be outdated config.yml file

Smart123s commented 1 year ago

Here's the latest config.yml, try copying the missing values from it. Also, is your bedrock account linked to a java account?

ACluco1 commented 1 year ago

Here's the latest config.yml, try copying the missing values from it. Also, is your bedrock account linked to a java account?

Yes, now i am able to join with Bedrock, when allowFloodgateNameConflict is set to true.

Smart123s commented 1 year ago

Here's the latest config.yml, try copying the missing values from it. Also, is your bedrock account linked to a java account?

Yes, now i am able to join with Bedrock, when allowFloodgateNameConflict is set to true.

Thanks for your help. Just don't forget that with that option enabled, a bedrock player with the same name as your java account's name will be able to auto login.

ACluco1 commented 1 year ago

Here's the latest config.yml, try copying the missing values from it. Also, is your bedrock account linked to a java account?

Yes, now i am able to join with Bedrock, when allowFloodgateNameConflict is set to true.

Thanks for your help. Just don't forget that with that option enabled, a bedrock player with the same name as your java account's name will be able to auto login.

Will they be able to autologin or just join the server? There is Authme installed so it would be better if it will be asking for login with password for bedrock players, or they will just autologin?

Smart123s commented 1 year ago

Right now, FastLogin doesn't store if the author registration was done via Java or Bedrock, so if any of them successfully join the server, they will get auto logged in.

There are plans to change this behavior in https://github.com/games647/FastLogin/pull/709, but that's been open for more than a year. Some of the code there is pretty messy, so I should refactor it a bit, but I don't really know when I'll get there.

On Mon, Mar 20, 2023, 13:14 luco1 @.***> wrote:

Here's the latest config.yml https://github.com/games647/FastLogin/blob/main/core/src/main/resources/config.yml, try copying the missing values from it. Also, is your bedrock account linked to a java account?

Yes, now i am able to join with Bedrock, when allowFloodgateNameConflict is set to true.

Thanks for your help. Just don't forget that with that option enabled, a bedrock player with the same name as your java account's name will be able to auto login.

Will they be able to autologin or just join the server? There is Authme installed so it would be better if it will be asking for login with password for bedrock players, or they will just autologin?

— Reply to this email directly, view it on GitHub https://github.com/games647/FastLogin/issues/982#issuecomment-1476119989, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGZJFZB2L6TNUY76NKWSCFLW5BC3NANCNFSM6AAAAAAULC6FEE . You are receiving this because you commented.Message ID: @.***>