games647 / FlexibleLogin

A Sponge minecraft server plugin for second factor authentication
https://forums.spongepowered.org/t/8872
MIT License
87 stars 22 forks source link

People can drop items before they login into the account #35

Closed 5igm closed 8 years ago

5igm commented 8 years ago

https://github.com/games647/FlexibleLogin/issues/34#issuecomment-243394760 The problem is still existing. Now, if people use "q" to try to drop some items before login, items will not be dropped on the ground, but items will be deleted.

games647 commented 8 years ago

That's a Sponge/Forge issue

games647 commented 8 years ago

I created a ticket on Sponge's side.

5igm commented 8 years ago

@games647 Thank you very much.

5igm commented 8 years ago

Dose it be fixed?

5igm commented 8 years ago

@games647

games647 commented 8 years ago

You don't need to ping me. I'm already subscribed to this topic by answering to it.

I thought I get a response for this: https://github.com/SpongePowered/SpongeCommon/issues/528

5igm commented 8 years ago

Does it mean the bug has been fixed? In addition, players can use items before they login into server.

games647 commented 8 years ago

In addition, players can use items before they login into server.

I tried it. It's prevented for me.

5igm commented 8 years ago

I installed BloodMagic-1.9.4-2.0.4-56 mod in my server. Some players said they can use "Sacrificial Dagger" before they login. "Sacrificial Dagger" is used to reduce the health of owner to save as energy. In addition, has this bug, https://github.com/SpongePowered/SpongeCommon/issues/528, been fixed in latest sponge?

games647 commented 8 years ago

Just try it out.

5igm commented 8 years ago

Thank you very much.

5igm commented 8 years ago

The problem still exists. https://my.pcloud.com/publink/show?code=XZsTWWZQ3JTnXviuybi2i8H3UcTXHhBxzwX

5igm commented 8 years ago

Do you still notice here? @games647

games647 commented 8 years ago

That's not a Flexible Login issue

5igm commented 8 years ago

Should I report this to spongeforge?

games647 commented 8 years ago

Yes

ghost commented 7 years ago

I think this issue should be opened. If you cannot deny drop items before player authorized you should save inventory when player disconnected, then load when player succesfully logged and authorized.

I think not a sponge problem.

games647 commented 7 years ago

@hunter688

I think not a sponge problem.

I think it is, if there is an event for it and you cancel it, but the item will be still removed from the inventory. (and it's not only client side.)