search

games647 / ScoreboardStats

Bukkit plugin for customizing the sidebar of the scoreboard feature from minecraft
https://dev.bukkit.org/bukkit-mods/scoreboardstats/
MIT License
28 stars 45 forks source link

Add rank to stats & API #4

Closed punkeel closed 10 years ago

punkeel commented 11 years ago

:)

not tested, may fail ... I suppose it doesn't, but not 100% sure

games647 commented 11 years ago

Well you fixed really some idiot mistakes by me but one problem I have this your code. The rank doesn't update if it was changed.

If you use Eclipse here is a little node: You can configurate you many spaces a Eclipse will make for a indent. Set it to 4. I am not the only one who don't like so many spaces for one indent.

punkeel commented 11 years ago

How to update rank without flooding DB ? +I'm using Intellij Idea "default config"

games647 commented 11 years ago

Maybe with a schedule?

Lol it's default. I didn't know that. I used IntelliJ only for his good inspection tools. (IntelliJ have so many checks even some are deactivated as default) If you compare it with other IDE's you will find out that IntelliJ have the most.

punkeel commented 11 years ago

A schedule ... to clear cache ? With a check if there is someone logged in :) ? Next push will be failed, as IJ Idea doesn't recognize "no modification" as a valid reason not to commit EDIT IJ Idea now configured not to use tab character

buildhive commented 11 years ago

games647 » ScoreboardStats #25 FAILURE Looks like there's a problem with this pull request (what's this?)

games647 commented 11 years ago

You commented to much out in the VariableList.

[ERROR] /scratch/jenkins/workspace/games647/ScoreboardStats/src/main/java/com/github/games647/scoreboardstats/scoreboard/VariableReplacer.java:[199,25] cannot find symbol symbol: variable CLAN_KDR location: class com.github.games647.variables.VariableList [ERROR] /scratch/jenkins/workspace/games647/ScoreboardStats/src/main/java/com/github/games647/scoreboardstats/scoreboard/VariableReplacer.java:[219,25] cannot find symbol

punkeel commented 11 years ago

Yep, just seen the "console output" tab ... Useful ! :) BTW, sorry for the mess :(

punkeel commented 11 years ago

It auto updates as the players get cached and recached :)

games647 commented 11 years ago

I tried this in the last day and I noticed that the rank feature doesn't work

punkeel commented 11 years ago

Currently using it on my server, can you tell what "version" you used ? (killstreak, kills, mobkills) ? Thanks :)

games647 commented 11 years ago

Wow fast respond. I tried it with the newest version. If you really test it, when its really weird.

punkeel commented 11 years ago

I tried to patch my commit with your version and ... Wow, hate the changes :(

games647 commented 11 years ago

Why, bad code?

punkeel commented 11 years ago

Maybe my "merge" were the bad code's origin, but I didn't really get the cache system .. Don't know how the data are set ... (and it was midnight past, so went to bed without further look' ) :)

games647 commented 11 years ago

I mean do you think that my current code is bad?

punkeel commented 11 years ago

No, but not compatible with my commit .. I think