search

gameshelf / gameshelf.github.io

NOT MAINTAINED ANYMORE
https://gameshelf.github.io/
28 stars 7 forks source link

Collection not loading #45

Closed fromeea closed 5 years ago

fromeea commented 5 years ago

When I try to view my collection the working wheel never stops spinning after BGG finishes processing. I have used your site in the past without issue but in the last couple months this issue has occurred. It does display my "Latest 100 Plays" without issue.
My username on BGG is fromeea.

junqdu commented 5 years ago

Owned | 2770

@fromeea interesting, was you collection always that big?

fromeea commented 5 years ago

Yes. It has been in the 2500+ range for a long time. I have not done any big jumps recently. Just slow growth.

If you need a video or screenshots let me know.

Thanks, Eric

Get Outlook for iOShttps://aka.ms/o0ukef

From: Jun Du notifications@github.com Sent: Tuesday, June 11, 2019 1:01:12 AM To: gameshelf/gameshelf.github.io Cc: fromeea; Mention Subject: Re: [gameshelf/gameshelf.github.io] Collection not loading (#45)

Owned | 2770

@fromeeahttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ffromeea&data=02%7C01%7C%7Cd98b68011e6a4de934c508d6ee323572%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636958296737728753&sdata=ILXwZ0%2F%2F4AJqTX5%2Fqek5U3fE0%2BbzUu9oMd3jZyklt%2Bc%3D&reserved=0 interesting, was you collection always that big?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fgameshelf%2Fgameshelf.github.io%2Fissues%2F45%3Femail_source%3Dnotifications%26email_token%3DAMKLFVDSQDWRR3IADVE6ESDPZ45SRA5CNFSM4HW2D42KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXMA6KI%23issuecomment-500698921&data=02%7C01%7C%7Cd98b68011e6a4de934c508d6ee323572%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636958296737738751&sdata=GoCnjSNWCoCMEB0u9i%2BSixckeCRstB8XROl%2Fvgbkank%3D&reserved=0, or mute the threadhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAMKLFVCEVU5CQQYWXMLIYHDPZ45SRANCNFSM4HW2D42A&data=02%7C01%7C%7Cd98b68011e6a4de934c508d6ee323572%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636958296737748762&sdata=EHnaIhJuOYNFCASag3%2BcGbEnKUeYMRBm5NSmvVrxdic%3D&reserved=0.

junqdu commented 5 years ago

@fromeea I did a bit of investigation on the issue, it appeared that your data just exceed the limit of localStorage of the browser, which is 10MB. It seems like it is fixable by using another type of storage instead of localStorage, IndexedDB.

I been quite busy with work and life, but I might be able to implement the fix maybe this weekend or the next.

fromeea commented 5 years ago

Thank you for investigating this issue. Please let me know when you have implemented the fix.

Eric.

From: Jun Du notifications@github.com Sent: Wednesday, June 12, 2019 3:10 PM To: gameshelf/gameshelf.github.io Cc: fromeea; Mention Subject: Re: [gameshelf/gameshelf.github.io] Collection not loading (#45)

@fromeeahttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ffromeea&data=02%7C01%7C%7C7fb69cdcdf1648285cb008d6ef71ffa9%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636959670229023304&sdata=gOCJUfmk6oJelrVXSS%2BjDY43cTzvTxP577vYSXyd6UM%3D&reserved=0 I did a bit of investigation on the issue, it appeared that your data just exceed the limit of localStorage of the browser, which is 10MB. It seems like it is fixable by using another type of storage instead of localStorage, IndexedDB.

I been quite busy with work and life, but I might be able to implement the fix maybe this weekend or the next.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fgameshelf%2Fgameshelf.github.io%2Fissues%2F45%3Femail_source%3Dnotifications%26email_token%3DAMKLFVBNZOO7DYQFQQURAQ3P2FJ2ZA5CNFSM4HW2D42KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXRVBOI%23issuecomment-501436601&data=02%7C01%7C%7C7fb69cdcdf1648285cb008d6ef71ffa9%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636959670229043326&sdata=Pq0pxWz6D1jCAmMDdUJJFVVbvR0kYlfwR0uMkaQGXGM%3D&reserved=0, or mute the threadhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAMKLFVCDJS7CMGULKOD7LKTP2FJ2ZANCNFSM4HW2D42A&data=02%7C01%7C%7C7fb69cdcdf1648285cb008d6ef71ffa9%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636959670229063336&sdata=qqrOHWW6S2sH%2FBEXdd4OEVKJgBZgn3jAxK1doYu0VcM%3D&reserved=0.

junqdu commented 5 years ago

@fromeea it should be fixed now, if you got to the Help page and check the "Disable Local Storage", you should be able to load your collection again.

In case you are wondering, I experimented with IndexedDB, but failed to implemented for our usage, so I went with disabling the caching feature.

fromeea commented 5 years ago

It works great! It is really nice to have it back!

From: Jun Du notifications@github.com Sent: Monday, August 12, 2019 3:26 AM To: gameshelf/gameshelf.github.io gameshelf.github.io@noreply.github.com Cc: fromeea fromeea@hotmail.com; Mention mention@noreply.github.com Subject: Re: [gameshelf/gameshelf.github.io] Collection not loading (#45)

@fromeeahttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Ffromeea&data=02%7C01%7C%7C34b65f85c60d4a43837208d71efed2f8%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637011952115091339&sdata=waetrZv0XPQjglHyzJ1sqg5l%2BYW4r7w98BrgT7DhgNY%3D&reserved=0 it should be fixed now, if you got to the Help page and check the "Disable Local Storage", you should be able to load your collection again.

In case you are wondering, I experimented with IndexedDB, but failed to implemented for our usage, so I went with disabling the caching feature.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fgameshelf%2Fgameshelf.github.io%2Fissues%2F45%3Femail_source%3Dnotifications%26email_token%3DAMKLFVG2GHJ32CMIQ5O7QWTQEENETA5CNFSM4HW2D42KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4B3UHY%23issuecomment-520337951&data=02%7C01%7C%7C34b65f85c60d4a43837208d71efed2f8%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637011952115101350&sdata=ogUM2so8YgGvYKmNKrB6e3Q5p6L7BTalS0ZVGHhthTw%3D&reserved=0, or mute the threadhttps://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAMKLFVBR5KJKO4ULE6YTYZ3QEENETANCNFSM4HW2D42A&data=02%7C01%7C%7C34b65f85c60d4a43837208d71efed2f8%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637011952115111355&sdata=yM8fec0PD0mwBynCQSAelQYHFsJdHVfRKh7BCzSst8I%3D&reserved=0.