gamestabled / OoT3D_Randomizer

Other
200 stars 42 forks source link

Issues with Adult Masks #502

Open wiznillyp opened 2 years ago

wiznillyp commented 2 years ago

Build: Nightly-b05891

Several issues with Adult Masks and (maybe) Fast Bunny Hood:

  1. Animation - This PR fixes the animation for young link, but its still broken for Adult Link if "Adult Masks" is enabled. Putting on Hover boots when the bunny hood is on, is, comically even faster.
  2. Adult Trade Sequence when a mask is on (at least the bunny hood) as adult, the adult mask trade sequence breaks in that items are not able to be traded as normal. A weird dialogue opens instead.

This happens at least at Biggoron with the Eyedrops and LH Lab with the frog.

wiznillyp commented 2 years ago

More details:

2 above still occurs in Nightly-e5ed86 when the new "Ignore masks" setting is enabled at the LH Lab Frog.

Kewlan commented 2 years ago

2: Along with the frog, I just tested all other trade items too. It all works with the setting and mask on. Sometimes when attempting to show an item it won't work the first time, and you'll have to show it a second time. This usually happens with the frog and the odd mushroom, and it has been like this since it was first implemented. This is probably what you encountered.

wiznillyp commented 2 years ago

@Kewlan Thanks for the response.

I have seen the behavior that you mentioned (works on the second attempt) since opening this issue. However, with the case that I was reporting, several attempts, to hand the eye drops failed. I even tried reloading the area to no avail.

However, removing the mask remedied the issue immediately.

HylianFreddy commented 2 years ago

I don't think there's an issue with the adult Link animation, the speed is increased like it is for child Link. I checked both on the latest version (Nightly-64ffb6), and on the Nightly-b05891.

https://user-images.githubusercontent.com/82058772/167930831-c59ce4ca-5b7c-46e8-97ac-21692b99b668.mp4

wiznillyp commented 2 years ago

@HylianFreddy Its a manner of opinion, but it still looks a bit fast to me, not a big deal. Have you tried with Hover boots?