search

gamification-survey-platform / server

0 stars 0 forks source link

Manual allocation of reviews is not consistent #102

Open drwlodarski opened 4 months ago

drwlodarski commented 4 months ago

Whenever I manually assign a review to a student - drag and drop his name from the column on the left, to the "reviewee" UI component, it appears as greyed out. Once I log in the student view, the review does not appear. I did the same action for the same student but a different reviewee, and it worked.

image image

Could you please investigate what happens? Manual assignment of reviews used to work last semester.

hanqidS2023 commented 4 months ago

Looks like this is more like a FE issue - the auto sorting mechanism, as when I disabled sorting, there was no issue.

When dragging, the length of the review list changes, so it might be messed up. I recommend that we don't do sorting, or we only sort it once after we getting the response from BE. What do you think?

drwlodarski commented 4 months ago

I know there is the auto sorting mechanism in place but I don't believe this is the core of the problem. Two out of three reviews that I allocated for the same student appeared "greyed out" and were not allocated afterall (not visible on student's end). The third one (in order) was successfully allocated - what could explain this inconsistent behaviour? Is it the number of reviews for a reviewee?

hanqidS2023 commented 4 months ago

I think this is the FE issue. In the FE code, when the cursor hovers through a reviewee(no matter you release your mouse or not), the review will be greyed out, it will not send a request to BE to create a review unless you drop your cursor on the reviewee. However, if you at the end didn't choose to select this reviewee, the "greyed out" effect will still be there. Since we have the auto sorting mechanism, it makes this situation worse as the list is changing. I will try fix the hover function on FE and see how it works