gammapy / enrico

Enrico helps you with your Fermi data analysis
http://enrico.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
22 stars 26 forks source link

Custom Ebin binning, Component analysis following 4FGL #148

Closed mireianievas closed 4 years ago

mireianievas commented 4 years ago
davidsanchez commented 4 years ago

Thanks a lot do you know the Fermi team recommendations for the energy dispersion ?

mireianievas commented 4 years ago

Thanks a lot do you know the Fermi team recommendations for the energy dispersion ?

They seem to recommend applying them globally (particularly if you are going below a few hundred MeV, https://fermi.gsfc.nasa.gov/ssc/data/analysis/documentation/Pass8_edisp_usage.html) except for the diffuse components. Fermipy also seems to enable it by default (https://fermipy.readthedocs.io/en/latest/config.html).

PS. I discovered a few minor bugs related to the xml generation and component tagging in the code and an old piece of code for Front/Back events which looks to me like it is old and totally unneeded. I am doing some tests and I will probably make today another small pull request with the proposed changes.