Update to 4FGL-DR3 and add IAC clusters

gammapy / enrico

Enrico helps you with your Fermi data analysis

http://enrico.readthedocs.io/

BSD 3-Clause "New" or "Revised" License

22 stars 26 forks source link

Update to 4FGL-DR3 and add IAC clusters #165

Closed mireianievas closed 2 years ago

mireianievas commented 2 years ago

Main changes:

Adapt to the newest 4FGL-DR3. A couple of variables changed names (added trailing S, I'm unsure if it was intentional or a typo, Jean Ballet has been contacted).
Add IAC clusters to the list.
Fix an issue with PSF/DRM calculation, it should be done only for binned analyses.

davidsanchez commented 2 years ago

thanks a lot

mireianievas commented 2 years ago

Hi @davidsanchez I think you closed it without merging. Is there anything I should fix in the pull request? I anyway fixed a small issue in yesterday's pull request about the new 4FGL-DR3 Super Exponential cut-off models for pulsars. Not only was the variable name changed, but the model definitions themselves were changed, so I added the new ones to the xml_model class.

davidsanchez commented 2 years ago

indeed. my bad