search

gammapy / gamma-cat

An open data collection and source catalog for gamma-ray astronomy
https://gamma-cat.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
15 stars 17 forks source link

Fix checks for input/gammacat/gamma_cat_dataset.yaml #123

Open cdeil opened 7 years ago

cdeil commented 7 years ago

This is a reminder issue for myself to fix up these checks:

ERROR:gammacat.cat:Datasets in `input/gammacat/gamma_cat_dataset.yaml`, but not in `input/data`: ['gammacat-hess-internal']
ERROR:gammacat.cat:Sources in `input/data`, but not in `input/gammacat/gamma_cat_dataset.yaml`: ['1996ApJ...460..644S', '1996ApJ...472L...9B', '1999A&A...342...69A', '1999A&A...350..757A', '1999ApJ...526L..81M', '2000PhDT.........6P', '2001ApJ...546..898A', '2002A&A...393...89A', '2003ApJ...583L...9H', '2003ICRC....5.2615T', '2003astro.ph..5275H', '2006A&A...449..223A', '2006ApJ...641..740R', '2008ApJ...679.1427A', '2009ApJ...691L..13D', '2009ApJ...698L..94A', '2011ApJ...738....3A', '2012ApJ...753..159A', '2012ApJ...754L..10A', '2012arXiv1205.0719D', '2014ApJ...780..168A', '2016arXiv161003751S', '2017ApJ...834....2A', 'lightcurves']

Maybe best to keep that internal file for now, but introduce a helper function that prints source_id for those missing refs (so that it's easier to add manually).

cdeil commented 7 years ago

I've addded the missing papers to input/gammacat/gamma_cat_dataset.yaml. There's still this, i.e. the check needs to be adapted to work on index files and properly excluded file lists:

ERROR:gammacat.catalog:Datasets in `input/gammacat/gamma_cat_dataset.yaml`, but not in `input/data`: ['gammacat-hess-internal']
ERROR:gammacat.catalog:Sources in `input/data`, but not in `input/gammacat/gamma_cat_dataset.yaml`: ['lightcurves']