search

gammapy / gamma-cat

An open data collection and source catalog for gamma-ray astronomy
https://gamma-cat.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
15 stars 17 forks source link

Reorganisation of table of contents on webpage #200

Closed pdeiml closed 6 years ago

pdeiml commented 6 years ago

I reorganised the structure of the table of content which can be seen on the left side on RTD. IMO it is a better to merge the data section and the user section and have only three main topics which describe gamma-cat in general (about), the user documentation and the contributor documentation, respectively.

Moreover, I added links to download the catalog files.

pdeiml commented 6 years ago

Removed update output commit in https://github.com/gammapy/gamma-cat/pull/199

pdeiml commented 6 years ago

Ok, you can merge it

cdeil commented 6 years ago

Should the changes to gammacat/webpage.py be here? Or are they a duplicate from #199?

It's not clear to me if this is an improvement or not from looking at the diff.

Could you please post the updates HTML webpage somewhere for review? E.g. at your institute on a webserver, or push to a private repo you have and e.g. use https://rawgit.com to quickly have a static webpage.

Alternatively, sometimes just pasting screenshots into the PR discussion can be a nice way to show what changed.

pdeiml commented 6 years ago

Ok, take a look now. As I said, it was a bit of a test. This webpage.py commit is the same as in 199 and I thought that as soon as you merge 199 this commit will disappear here. Unfortunately, it didn't. But a short rebase fixed everything :-)

The produced _build directory can be found here: https://github.com/pdeiml/html

RTM

cdeil commented 6 years ago

@pdeiml - please always share a link like in this case https://rawgit.com/pdeiml/html/master/html/index.html in the future for webpage preview after restructuring. And note that if you edit an existing comment, no new notification is sent, i.e. in this case I didn't see that you had a preview available like I asked, and thus didn't react here.

I'm very short on time this week, can't do a detailed review here. I think this is going in a good direction, merging your stuff now.