search

gammapy / gamma-cat

An open data collection and source catalog for gamma-ray astronomy
https://gamma-cat.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
15 stars 17 forks source link

2015A%26A...577A.131H marked as complete but LC data missing #217

Open GernotMaier opened 6 years ago

GernotMaier commented 6 years ago

LC data from Fig 2 and 3 of 1FGL J1018.6–5856 (binary) is missing

(and paper is marked as complete, which is not correct)

cdeil commented 6 years ago

Looks like this is a HESS paper https://gamma-cat.readthedocs.io/data/references/2015A%26A...577A.131H.html and indeed the LC data is missing, but is available here: https://www.mpi-hd.mpg.de/hfm/HESS/pages/publications/auxiliary/auxinfo_HESSJ1018

@pdeiml - do you have time to add the LC data?

pdeiml commented 6 years ago

In principle I can do this but - as I am not familiar with lightcurves - I don't know which table on https://www.mpi-hd.mpg.de/hfm/HESS/pages/publications/auxiliary/auxinfo_HESSJ1018 I should add as a lightcurve.

cdeil commented 6 years ago

@pdeiml - The task here would be to take the ECSV table under "H.E.S.S. run-by-run lightcurve" and also under "H.E.S.S. orbitally folded lightcurve" and add them as two LC ECSV files to gamma-cat. You should look at other examples with a LC or a binary for the column names we use. Then @GernotMaier or I could review your PR.

If it's not clear what to do, let me know and I'll do this task.

pdeiml commented 6 years ago

Well, in principle it is clear. But I don't know which information is necessary and which one is not. I think that it is easier if you add the lightcurves instead of I add them and ask you 10 times.