gammapy / gamma-cat

An open data collection and source catalog for gamma-ray astronomy
https://gamma-cat.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
15 stars 17 forks source link

Quite a number of corrections to VERITAS data #221

Closed GernotMaier closed 6 years ago

GernotMaier commented 6 years ago

This pull requests consist of a number of corrections for:

I've cross-checked all existing spectral models and spectra for VERITAS - hope that the worst mistakes are corrected.

cdeil commented 6 years ago

@GernotMaier - OK if I only give this a cursory review and then merge?

I think double-checking the numbers against the paper would take me a lot of time here.

GernotMaier commented 6 years ago

Yes - that is fine. These are all 'obvious' mistakes.

(and I am trying to organise currently a file-by-file review inside VERITAS to cross check all values with the publications)

cdeil commented 6 years ago

OK. We can / should also improve the scripts. With ~ 1 day or work we can have validation for a lot of data entry stuff, e.g. units.

GernotMaier commented 6 years ago

I've cross checked 2015ApJ...812...60B with the paper and the factor of 10 correction is needed.

This is the only VERITAS detection with such a problem. I've checked all VERITAS sources and for all the flux points and spectral points agree now.