search

gammapy / gamma-cat

An open data collection and source catalog for gamma-ray astronomy
https://gamma-cat.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
15 stars 17 forks source link

Bug in telescope names? #232

Closed pdeiml closed 6 years ago

pdeiml commented 6 years ago

In https://github.com/gammapy/gamma-cat/blob/master/input/data/2003/2003ApJ...598..242A/info.yaml, the telescope is 'tibet' which is correct with respect to the paper. But the telescope definitions in https://github.com/gammapy/gamma-cat/blob/master/input/schemas/basic_source_info.schema.yaml do not contain 'tibet'. Should we add it here?

cdeil commented 6 years ago

yip

pdeiml commented 6 years ago

I found 'tactic' as a second telescope which is not defined in https://github.com/gammapy/gamma-cat/blob/master/input/schemas/basic_source_info.schema.yaml.

Added both in https://github.com/gammapy/gamma-cat/pull/233

cdeil commented 6 years ago

Fixed by @pdeiml in #233 .