Detail view for 3FHL sources

gammapy / gamma-sky

Portal to the gamma-ray sky

http://gamma-sky.net/

MIT License

6 stars 3 forks source link

Detail view for 3FHL sources #74

Closed vorugantia closed 7 years ago

vorugantia commented 7 years ago

@cdeil - In this PR I filled out the detail view for 3FHL sources. This is what it currently looks like:

Let me know what can be changed/reformatted.

Also - for extended 3FHL sources, we need to load additional data from Gammapy (SourceCatalog3FHL().data_extended) to fill for their detail pages in gamma-sky.net. I can do that later and add the commit to this PR.

cdeil commented 7 years ago

Looks pretty good. I would suggest to merge soon and move on, and leave further polishing to later.

Small comments:

I always give units in this order: cm-2 s-1 GeV-1 because then it's more similar to the units for integral fluxes cm-2 s-1 and I this it to more common and thus easier to read
"HEP" is probably an acronym that many won't recognise, so maybe write "Highest energy photon: 42 GeV (probability: 99%)"

vorugantia commented 7 years ago

I made these minor fixes. Merging the PR...