search

gammapy / gamma-sky

Portal to the gamma-ray sky
http://gamma-sky.net/
MIT License
6 stars 3 forks source link

Routing connection from popups to detail pages #84

Closed vorugantia closed 6 years ago

vorugantia commented 6 years ago

@cdeil - I'm opening this as a PR just so you can comment on the style of the buttons/links to the popup/detail page.

Here's what the popup looks like for gamma-cat sources:

popuo

I didn't do much styling, but how does the "More information" link look? Do you think it would look better as a button instead?

vorugantia commented 6 years ago

The URL now includes glon/glat coordinate parameters, and the Aladin map is initialized to read these coordinates from the URL. That means people can now share map views with each other!

This is starting to become a big PR... I don't think you have to review everything. If you want, you can just check how I moved the Aladin Lite "config" over from map.component.ts to map-state.ts.

vorugantia commented 6 years ago

Comments have been addressed. I finished linking the popup to the cat detail page, so I'm closing this PR. In another PR I can make the URL parameterization more advanced.