search

gammapy / gamma-sky

Portal to the gamma-ray sky
http://gamma-sky.net/
MIT License
6 stars 3 forks source link

add more entries in search field for TeV sources #92

Closed vorugantia closed 6 years ago

vorugantia commented 6 years ago

The search field now includes the gamma_names, fermi_names, and other_names of sources in the TeV catalog. This PR addresses #90 .

vorugantia commented 6 years ago

I don't see why my changes to the code should make travis-ci fail... I will investigate later.

cdeil commented 6 years ago

travis-ci fails are unrelated, I'll fix in master. Merging this now.

I think the problem is here: https://travis-ci.org/gammapy/gamma-sky/builds/275265978#L2968

cat = SourceCatalog3FHL(filename='input_data/3fhl.fits.gz')
table = Table.read(filename, hdu='LAT_Point_Source_Catalog')

With the version of Astropy being used now (Astropy 2.0.2, can be seen further up in the build log), one has to explicitly pass format='fits' to Table.read, the FITS file type is no longer inferred if the extension is .fits.gz.

This is just a guess, but I'll see if it's the case and fix in Gammapy.

cdeil commented 6 years ago

3FHL error should be fixed in f88f5bdc743923c681bd3bb8be77ded17be25f15 .