gammapy / gamma-sky

Portal to the gamma-ray sky
http://gamma-sky.net/
MIT License
6 stars 3 forks source link

Commit package-lock.json ? #93

Open cdeil opened 7 years ago

cdeil commented 7 years ago

@vorugantia - Should we commit package-lock.json? I keep getting this warning:

$ npm install
npm notice created a lockfile as package-lock.json. You should commit this file.

and this file keeps getting generated and show up with git status:

$ git status
On branch master
Your branch is up-to-date with 'origin/master'.

Untracked files:
  (use "git add <file>..." to include in what will be committed)

    package-lock.json

nothing added to commit but untracked files present (use "git add" to track)

So we should either commit it, or add it to .gitignore.

@vorugantia - I think we should just commit it, no? If you have time, could you read around a bit how it's used (i.e. how one updates it as new versions of the dependencies pinned there appear), and add a link or two to a good reference to the gamma-sky.net dev docs?

ShankariManohar commented 5 years ago

You can use "git add -A" in cmd to commit the package-lock.json