Closed fabiopintore closed 1 year ago
Thanks @fabiopintore! I have not checked the results yet, but my first guess on the interpolation methods would be to use a log scaling for the energy axis, linear for the time axis and log scaling for the values. For the latter see https://github.com/gammapy/gammapy/blob/main/gammapy/maps/region/ndmap.py#L414
If you have not tried this yet, please include it as one of the options.
I've updated the notebook with the event sampling tests for energy-dependent sources. I realized that the interpolation method of the
MapAxis
and that used ininterp_by_coord
intoLightCurveTemplateTemporalModel.evaluate
can give wrong estimates of the model. The notebook shows 4 different tests:linear
interpolation scale for time axis, withnearest
neighbour interpolation inevaluate
linear
interpolation scale for time axis, withlinear
interpolation inevaluate
log
interpolation scale for time axis, withnearest
neighbour interpolation inevaluate
log
interpolation scale for time axis, withlinear
interpolation inevaluate
The first two cases are those that provides the best results. @adonath @registerrier @AtreyeeS , please have a look at it.