search

gammapy / gammaskynet-gamma2016

Gamma 2016 conference poster contribution for gamma-sky.net
MIT License
0 stars 2 forks source link

change TeV catalog to gamma-cat #5

Closed vorugantia closed 7 years ago

vorugantia commented 8 years ago

Very small PR, I'm just changing our TeV catalog that we use to gamma-cat.

cdeil commented 8 years ago

👍

You should also link to https://github.com/gammapy/gamma-cat/ and add a (very short) section or at least paragraph on this.

We'll write a separate paper later, but for now a little info should be given what this new catalog is.

I'm not sure https://gammapy.github.io/gamma-cat/ will be the long-term home of this or if I should buy gamma-cat.net or host it as a sub-page of gamma-sky.net, so for now I think linking to https://github.com/gammapy/gamma-cat from the proceeding is best.

vorugantia commented 8 years ago

@cdeil - Added text for Introduction and Idea sections. Tomorrow I'll start on Features section and see how far I get.

cdeil commented 8 years ago

@vorugantia - Thanks!

I've left some LaTeX formatting comments inline. I haven't read the text yet.

Can you re-format the paragraphs so that the line lengths are a little shorter? If you look on Github at the diff you'll see that every line breaks and is hard to read / review. I use a shortcut in Atom to do this. It might be built-in or this plugin (https://atom.io/packages/wrap-lines), I'm not sure at the moment.

vorugantia commented 8 years ago

Okay, I made all of the changes you suggested. You can either start reviewing the text now or just wait until I finish everything hopefully this weekend. Then we have ~ 2 weeks to edit before the submission deadline.

cdeil commented 8 years ago

I left a few inline comments.

My suggestion would be that you now just go ahead, and fill out the remaining parts to get to a first complete draft by yourself, and then I'll review it as a whole. (This is mostly motivated by me being very busy with another project this week and we have guests on the weekend, so I'll only have time to read it next week.)

vorugantia commented 7 years ago

I finished the first draft of the paper in the latest commit. Ready for you to make any changes/suggestions. The deadline is coming up this Saturday the 1st (I probably should have finished the draft sooner...) so we should get a final draft done in ~4-5 days.

I have some questions that I left as TODO messages in the text. Let me know your response for each of them. Also, I left the References section at the top of the paper for now - we will take that out eventually.

cdeil commented 7 years ago

@vorugantia - Thanks!

I'm merging this now. And I'll try to find time to read over it and make some edits later today.

We should send around a draft to all co-authors tomorrow latest. It doesn't have to be perfect, we can remove some things.

The webpage will likely change / extend quite a bit in the coming year anyways.

The main thing is to have a citable reference that describes the idea of the webpage.