Allow hist file into trigger rate application

[VictorBarbosaMartins]

In this PR, I implemented some improvements to the trigger rate tool that allows it to calculate the trigger rate for a given an input .hdata.zst file (and not only an .simtel.zst file as it is in main now). However, the configuration used for the simulation is not propagated to the .hdata.zst as it is to the .simtel.zst, which means we do not have the view cone and the energy range used, which are both necessary for the operation of this tool. Therefore, if passing a .hdata to the tool, --energy_range and --view_cone also have to be passed. One can test this with the new integration test simtools-calculate-trigger-rate --config tests/integration_tests/config/calculate_trigger_rate_one_file_hdata.yml. Not passing --energy_range or --view_cone for an input .hdata file will lead to error, which is tested in the unit tests.

I believe the low coverage by sonarqube is due to the changes in the application itself, which we do not test with unit tests at the moment, so I suggest to ignore it.

Closes #934.

[ctao-dpps-sonarqube[bot]]

• 22.10% Coverage on New Code (is less than 80.00%)

Analysis Details

0 Issues

• 0 Bugs
• 0 Vulnerabilities
• 0 Code Smells

Coverage and Duplications

• 22.10% Coverage (71.10% Estimated after merge)
• 0.00% Duplicated Code (0.10% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

[ctao-dpps-sonarqube[bot]]

• 26.50% Coverage on New Code (is less than 80.00%)

Analysis Details

0 Issues

• 0 Bugs
• 0 Vulnerabilities
• 0 Code Smells

Coverage and Duplications

• 26.50% Coverage (70.40% Estimated after merge)
• 0.00% Duplicated Code (0.10% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

[VictorBarbosaMartins]

Hi @GernotMaier, thanks for the comments. I think I addressed all of them. Please let me know what to do in regard to the type=str or type=float. Also please have a look again once tests pass. If they fail, I will deal with them later.

[ctao-dpps-sonarqube[bot]]

• 25.20% Coverage on New Code (is less than 80.00%)

Analysis Details

0 Issues

• 0 Bugs
• 0 Vulnerabilities
• 0 Code Smells

Coverage and Duplications

• 25.20% Coverage (70.70% Estimated after merge)
• 0.00% Duplicated Code (0.10% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

[VictorBarbosaMartins]

Thanks again @GernotMaier. Will wait until the tests pass again to merge.

[ctao-dpps-sonarqube[bot]]

• 68.50% Coverage on New Code (is less than 80.00%)

Analysis Details

0 Issues

• 0 Bugs
• 0 Vulnerabilities
• 0 Code Smells

Coverage and Duplications

• 68.50% Coverage (72.90% Estimated after merge)
• 0.00% Duplicated Code (0.10% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube