gammasim / simtools

Tools and applications for the Simulation System of the CTA Observatory.

https://gammasim.github.io/simtools

BSD 3-Clause "New" or "Revised" License

10 stars 1 forks source link

explicity include for coverage in sonar #1003

Closed GernotMaier closed 3 months ago

GernotMaier commented 3 months ago

Sonarq is showing the wrong coverage, as it includes the tests directory in the calculation.

Add here some options to exclude those files (following the configuration file from calibpipe.

I think we will see if this works only after 'merge to main' and 'run unit tests on main'

ctao-dpps-sonarqube[bot] commented 3 months ago

Passed

Analysis Details

0 Issues

0 Bugs
0 Vulnerabilities
0 Code Smells

Coverage and Duplications

No coverage information (0.00% Estimated after merge)
No duplication information (0.10% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

ctao-dpps-sonarqube[bot] commented 3 months ago

Passed

Analysis Details

0 Issues

0 Bugs
0 Vulnerabilities
0 Code Smells

Coverage and Duplications

No coverage information (72.50% Estimated after merge)
No duplication information (0.10% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

ctao-dpps-sonarqube[bot] commented 3 months ago

Passed

Analysis Details

0 Issues

0 Bugs
0 Vulnerabilities
0 Code Smells

Coverage and Duplications

No coverage information (72.00% Estimated after merge)
No duplication information (0.00% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

maxnoe commented 3 months ago

Why are you not running coverage on merge requests? The reporting of the coverage on newly added / modified lines is I think one of the most valuable things about this kind of setup.

GernotMaier commented 3 months ago

We are still using codecov for this.

First wanted to get familiar with sonarq and to fix the issues so that it gives consistent results for us.