gammasim / simtools

Tools and applications for the Simulation System of the CTA Observatory.

https://gammasim.github.io/simtools

BSD 3-Clause "New" or "Revised" License

9 stars 1 forks source link

Improve simulation configuration for corsika and simtel simulations. #1026

Closed GernotMaier closed 1 week ago

GernotMaier commented 1 week ago

Improve simulation configuration for corsika and simtel simulations.

Added simulation_configuration=["software", "corsika_configuration"] to allow for the configuration of simulation software (e.g., corsika/simtel) or corsika configuration parameters (e.g. number of showers to be simulated).

Added array_layout model option to add especially array_layout_name to command line configuration.

Added functionality to the configuration model required to configure corsika parameters like erange, viewcone, cscatter:

for erange, viewcone: CommandLineParser.parse_quantity_pair requires a single string with a pair of quantities, e.g., "10 GeV 50 PeV" or "10GeV 50PeV" or "0deg 1.55deg"
for cscatter: CommandLineParser.parse_integer_and_quantity requires a single with with a pair consisting of an integer and a astropy.quantity (as needed for the core scatter keyword). This mean e.g., "5 1500m" or "5 1500 m".

Minor changes:

simplified handling of azimuth angle configuration
improved unit testing

Closes #1005

ctao-dpps-sonarqube[bot] commented 1 week ago

Passed

Analysis Details

2 Issues

0 Bugs
0 Vulnerabilities
2 Code Smells

Coverage and Duplications

100.00% Coverage (73.00% Estimated after merge)
0.00% Duplicated Code (0.10% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

ctao-dpps-sonarqube[bot] commented 1 week ago

Passed

Analysis Details

2 Issues

0 Bugs
0 Vulnerabilities
2 Code Smells

Coverage and Duplications

100.00% Coverage (73.00% Estimated after merge)
0.00% Duplicated Code (0.10% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

GernotMaier commented 1 week ago

Thanks for the review!

ctao-dpps-sonarqube[bot] commented 1 week ago

Passed

Analysis Details

2 Issues

0 Bugs
0 Vulnerabilities
2 Code Smells

Coverage and Duplications

100.00% Coverage (73.00% Estimated after merge)
0.00% Duplicated Code (0.10% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

ctao-dpps-sonarqube[bot] commented 1 week ago

Passed

Analysis Details

2 Issues

0 Bugs
0 Vulnerabilities
2 Code Smells

Coverage and Duplications

100.00% Coverage (73.00% Estimated after merge)
0.00% Duplicated Code (0.10% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube