gammasim / simtools

Tools and applications for the Simulation System of the CTA Observatory.

https://gammasim.github.io/simtools

BSD 3-Clause "New" or "Revised" License

9 stars 1 forks source link

Review and improve job submission module #1034

Open GernotMaier opened 4 days ago

GernotMaier commented 4 days ago

Review after PR #989 has been reviewed and merged!!

Improve job submission module:

tested HTCondor submission on DESY cluster; minor improvements to allow to give additional options to condor submit
improved docstrings
improved naming: submit_command renamed to submit_engine
significantly improved coverage of simtools/job_execution/job_manager.py
added a short documentation page on running productions (incomplete)

Note!

This PR introduced a new dependency: pytest-mock.

ctao-dpps-sonarqube[bot] commented 4 days ago

Passed

Analysis Details

11 Issues

0 Bugs
0 Vulnerabilities
11 Code Smells

Coverage and Duplications

100.00% Coverage (89.40% Estimated after merge)
0.00% Duplicated Code (0.10% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

ctao-dpps-sonarqube[bot] commented 4 days ago

Passed

Analysis Details

11 Issues

0 Bugs
0 Vulnerabilities
11 Code Smells

Coverage and Duplications

100.00% Coverage (89.40% Estimated after merge)
0.00% Duplicated Code (0.10% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

ctao-dpps-sonarqube[bot] commented 4 days ago

Passed

Analysis Details

11 Issues

0 Bugs
0 Vulnerabilities
11 Code Smells

Coverage and Duplications

96.10% Coverage (89.60% Estimated after merge)
0.00% Duplicated Code (0.00% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

ctao-dpps-sonarqube[bot] commented 4 days ago

Passed

Analysis Details

11 Issues

0 Bugs
0 Vulnerabilities
11 Code Smells

Coverage and Duplications

100.00% Coverage (89.60% Estimated after merge)
0.00% Duplicated Code (0.00% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

ctao-dpps-sonarqube[bot] commented 4 days ago

Passed

Analysis Details

11 Issues

0 Bugs
0 Vulnerabilities
11 Code Smells

Coverage and Duplications

100.00% Coverage (89.60% Estimated after merge)
0.00% Duplicated Code (0.00% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

ctao-dpps-sonarqube[bot] commented 4 days ago

Passed

Analysis Details

11 Issues

0 Bugs
0 Vulnerabilities
11 Code Smells

Coverage and Duplications

92.50% Coverage (89.50% Estimated after merge)
0.00% Duplicated Code (0.00% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

ctao-dpps-sonarqube[bot] commented 4 days ago

Passed

Analysis Details

11 Issues

0 Bugs
0 Vulnerabilities
11 Code Smells

Coverage and Duplications

100.00% Coverage (89.60% Estimated after merge)
0.00% Duplicated Code (0.00% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

ctao-dpps-sonarqube[bot] commented 4 days ago

Passed

Analysis Details

11 Issues

0 Bugs
0 Vulnerabilities
11 Code Smells

Coverage and Duplications

100.00% Coverage (89.60% Estimated after merge)
0.00% Duplicated Code (0.00% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

ctao-dpps-sonarqube[bot] commented 4 days ago

Passed

Analysis Details

3 Issues

0 Bugs
0 Vulnerabilities
3 Code Smells

Coverage and Duplications

100.00% Coverage (89.60% Estimated after merge)
0.00% Duplicated Code (0.00% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

ctao-dpps-sonarqube[bot] commented 3 days ago

Passed

Analysis Details

3 Issues

0 Bugs
0 Vulnerabilities
3 Code Smells

Coverage and Duplications

100.00% Coverage (89.60% Estimated after merge)
0.00% Duplicated Code (0.00% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube