gammasim / simtools

Tools and applications for the Simulation System of the CTA Observatory.
https://gammasim.github.io/simtools
BSD 3-Clause "New" or "Revised" License
9 stars 1 forks source link

Generalize primary particle definition using scikit-hep/particle/ #1037

Open GernotMaier opened 3 days ago

GernotMaier commented 3 days ago

Review after PR #989 has been reviewed and merged!!

Allow a more flexible and future-proved definition of the primary particle types.

Primary particles for simulations can be chosen now from:

CORSIKA 8 is using PDG IDs, meaning with this PR the switch will be easier.

The primary particle is defined with two command line flags:

Requires to add a new dependency: scikit-hep/particle. Note that the PDG group also allows a python API, but it this has been released only recently and is a notably large package. Also does not allow to convert CORSIKA7 IDs to PDG IDs.

Closes #448

ctao-dpps-sonarqube[bot] commented 3 days ago

Passed

Analysis Details

0 Issues

Coverage and Duplications

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

ctao-dpps-sonarqube[bot] commented 3 days ago

Passed

Analysis Details

0 Issues

Coverage and Duplications

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

ctao-dpps-sonarqube[bot] commented 3 days ago

Passed

Analysis Details

0 Issues

Coverage and Duplications

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube