Closed GernotMaier closed 2 months ago
ctao-dpps-sonarqube[bot]
commented
3 months ago 
0 Bugs
0 Vulnerabilities
2 Code Smells
No coverage information (88.80% Estimated after merge)
0.00% Duplicated Code (0.10% Estimated after merge)Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w
ctao-dpps-sonarqube[bot]
commented
3 months ago
0 Bugs 0 Vulnerabilities 2 Code Smells
100.00% Coverage (88.50% Estimated after merge) 0.00% Duplicated Code (0.10% Estimated after merge)Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w
ctao-dpps-sonarqube[bot]
commented
3 months ago 
0 Bugs 0 Vulnerabilities 2 Code Smells
44.40% Coverage (88.50% Estimated after merge) 0.00% Duplicated Code (0.10% Estimated after merge)Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w
ctao-dpps-sonarqube[bot]
commented
3 months ago
0 Bugs 0 Vulnerabilities 0 Code Smells
50.00% Coverage (88.50% Estimated after merge) 0.00% Duplicated Code (0.10% Estimated after merge)Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w
ctao-dpps-sonarqube[bot]
commented
3 months ago
0 Bugs 0 Vulnerabilities 0 Code Smells 50.00% Coverage (88.50% Estimated after merge) 0.00% Duplicated Code (0.10% Estimated after merge)Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w
ctao-dpps-sonarqube[bot]
commented
3 months ago
0 Bugs 0 Vulnerabilities 0 Code Smells 50.00% Coverage (88.50% Estimated after merge) 0.00% Duplicated Code (0.10% Estimated after merge)Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w
ctao-dpps-sonarqube[bot]
commented
2 months ago
0 Bugs 0 Vulnerabilities 0 Code Smells 50.00% Coverage (88.50% Estimated after merge) 0.00% Duplicated Code (0.10% Estimated after merge)Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w
ctao-dpps-sonarqube[bot]
commented
2 months ago
0 Bugs 0 Vulnerabilities 0 Code Smells 50.00% Coverage (88.60% Estimated after merge) 0.00% Duplicated Code (0.00% Estimated after merge)Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w
ctao-dpps-sonarqube[bot]
commented
2 months ago
0 Bugs 0 Vulnerabilities 0 Code Smells 50.00% Coverage (89.20% Estimated after merge) 0.00% Duplicated Code (0.00% Estimated after merge)Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w
ctao-dpps-sonarqube[bot]
commented
2 months ago
0 Bugs 0 Vulnerabilities 0 Code Smells 50.00% Coverage (89.20% Estimated after merge) 0.00% Duplicated Code (0.00% Estimated after merge)Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w
ctao-dpps-sonarqube[bot]
commented
2 months ago
0 Bugs 0 Vulnerabilities 0 Code Smells 50.00% Coverage (89.20% Estimated after merge) 0.00% Duplicated Code (0.00% Estimated after merge)Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w
Try to address as many of the sonar issues as possible.
Most changes are trivial (e.g., the string literal issues) and won't need a thorough review. Reduce complexity issues are a bit trickier, but should also be covered unit tests.
Sonar is failing and this is because 'plot_camera.py' does not have any unit tests (there is not even a test file). So the coverage of all changes if <50%. I am inclined to ignore this as part of this issue to keep the number of changes on a reasonable level (and this is the reason why one of the unit tests is failing).