gammasim / simtools

Tools and applications for the Simulation System of the CTA Observatory.

https://gammasim.github.io/simtools

BSD 3-Clause "New" or "Revised" License

10 stars 1 forks source link

Minor bug fix to allow to run db_add_model_parameters_from_repository_to_db with SIMTOOLS_DB_SIMULATION_MODEL defined #1046

Closed GernotMaier closed 2 months ago

GernotMaier commented 2 months ago

The application db_add_model_parameters_from_repository_to_db uploads model parameters from a repository to the DB into a new DB with a name given on the command line --db_name.

Noticed that this application is not working when the environmental variable SIMTOOLS_DB_SIMULATION_MODEL is not defined. This is obviously dangerous, as we have to be sure that only data from the repository and not from another DB is uploaded.

This PR fixes this and db_add_model_parameters_from_repository_to_db is working now without SIMTOOLS_DB_SIMULATION_MODEL defined.

ctao-dpps-sonarqube[bot] commented 2 months ago

Passed

Analysis Details

0 Issues

0 Bugs
0 Vulnerabilities
0 Code Smells

Coverage and Duplications

100.00% Coverage (89.70% Estimated after merge)
0.00% Duplicated Code (0.00% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

GernotMaier commented 2 months ago

@Thanks for this!