gammasim / simtools

Tools and applications for the Simulation System of the CTA Observatory.
https://gammasim.github.io/simtools
BSD 3-Clause "New" or "Revised" License
10 stars 1 forks source link

Model parameters - load from file is experimental #1084

Open GernotMaier opened 4 months ago

GernotMaier commented 4 months ago

The possibility to overwrite model parameters using a simple yaml file (command line option --telescope_model_file) bypasses the validation steps. At this point there is a warning printed that it is an "experimental" feature. We might want to improve this in future.

(this has been introduced with PR #1081)

GernotMaier commented 2 weeks ago

I suggest to remove the experimental flag and replace it with a warning that this is a developer feature. I think it is fine to have functionality of this type.

Alternative would be to add the validation steps, which is probably not worth the time given that this is feature we use during development cycles only.