search

gammasim / simtools

Tools and applications for the Simulation System of the CTA Observatory.
https://gammasim.github.io/simtools
BSD 3-Clause "New" or "Revised" License
10 stars 1 forks source link

sim_telarray/CORSIKA output file names are different to current productions #1133

Open orelgueta opened 3 weeks ago

orelgueta commented 3 weeks ago

After the refactoring the filenames have a different structure than in the current official productions. Check if going back to the old style does not introduce complications in the code.

GernotMaier commented 3 weeks ago

At least some of the changes are result of trying to have a consistent naming of output files for all simtools. There had been minor differences between e.g., the ray tracing tools and the naming of files in productions.

The old style is definitely not more complicated, but it would be if files generated by the simulation pipeline follow a consistent naming pattern. Maybe we can improve how we use the routines in names.py.

orelgueta commented 3 weeks ago

One inconsistency was on purpose, the difference between CORSIKA output files and sim_telarray output files. However, that inconsistency we don't have to keep. What I would like to go back to is that the particle name is the first part of the file name. Event if that means it won't be the same as the ray-tracing tool, I think it's still worth it.

GernotMaier commented 3 weeks ago

This is fine with me - can you remind us how it was before and how it is now?

orelgueta commented 3 weeks ago

My suggestion is:

My assumption is that the label will contain the NSB level and perhaps additional info.

GernotMaier commented 3 weeks ago

My suggestion would to use this then in general for files of this type generated by simtools (and for ray tracing results, we replace gamma by e.g., psf or something similar).

orelgueta commented 3 weeks ago

Sounds good, I will try to do that wherever possible (once I finish with the current project).