gammasim / simtools

Tools and applications for the Simulation System of the CTA Observatory.

https://gammasim.github.io/simtools

BSD 3-Clause "New" or "Revised" License

10 stars 1 forks source link

Refactor validate_data_dict and improved testing #1199

Closed GernotMaier closed 1 month ago

GernotMaier commented 1 month ago

This is refactor PR with no change in functionality.

data_model.validate_data._validate_data_dict is too complex and we split here the function into several. Also address the issue of a missing test for the call of _validate_data_dict_using_json_schema.

Closes #1193

ctao-dpps-sonarqube[bot] commented 1 month ago

Passed

Analysis Details

0 Issues

0 Bugs
0 Vulnerabilities
0 Code Smells

Coverage and Duplications

100.00% Coverage (93.00% Estimated after merge)
0.00% Duplicated Code (0.00% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

ctao-dpps-sonarqube[bot] commented 1 month ago

Passed

Analysis Details

0 Issues

0 Bugs
0 Vulnerabilities
0 Code Smells

Coverage and Duplications

100.00% Coverage (93.00% Estimated after merge)
0.00% Duplicated Code (0.00% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

GernotMaier commented 1 month ago

@orelgueta - thanks for the review!

Let me know if it is ok to keep the if-statements. I really don't care, but have a slight preference to less lines of code.

ctao-dpps-sonarqube[bot] commented 1 month ago

Passed

Analysis Details

0 Issues

0 Bugs
0 Vulnerabilities
0 Code Smells

Coverage and Duplications

100.00% Coverage (93.00% Estimated after merge)
0.00% Duplicated Code (0.00% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube