EshitaJoshi commented 1 month ago

This PR fixes a bug in the function .get_parameter_value_with_unit() where the units were strings (eg. "['m', 's', 'null']") instead of a list. Null entries within this list of units were not being returned as dimensionless, but were instead raising the following error: ValueError: 'cm, deg, null, null' did not parse as unit: At col 9, null is not a valid unit. If this is meant to be a custom unit, define it with 'u.def_unit'. To have it recognized inside a file reader or other code, enable it with 'u.add_enabled_units'. For details, see https://docs.astropy.org/en/latest/units/combining_and_defining.html

Changes:

Units are now being converted from a string to a comma-separated list. This was not done using simtools.utils.general.convert_string_to_list() as some units have spaces within them, which this function would interpret as different entries in a list.
Null units in lists are treated as dimensionless.
A list of astropy quantities is returned if values are a list.
AttributeError added for the case where units are not provided (NoneType), in which case the function returns the value without a unit.