gammasim / simtools

Tools and applications for the Simulation System of the CTA Observatory.

https://gammasim.github.io/simtools

BSD 3-Clause "New" or "Revised" License

10 stars 1 forks source link

Introduce selective log levels via fixture #1221

Closed tobiaskleiner closed 2 weeks ago

tobiaskleiner commented 4 weeks ago

This PR adds a fixture to set the log level context. In some cases the context was added where it was previously missing. In some cases log levels where adjusted to better reflect the log message.

This adresses the problem that previously we set logger.setLevel(logging.DEBUG)for almost all unit tests.

ctao-dpps-sonarqube[bot] commented 4 weeks ago

Passed

Analysis Details

1 Issue

0 Bugs
0 Vulnerabilities
1 Code Smell

Coverage and Duplications

100.00% Coverage (93.10% Estimated after merge)
0.00% Duplicated Code (0.00% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

ctao-dpps-sonarqube[bot] commented 4 weeks ago

Passed

Analysis Details

0 Issues

0 Bugs
0 Vulnerabilities
0 Code Smells

Coverage and Duplications

100.00% Coverage (93.10% Estimated after merge)
0.00% Duplicated Code (0.00% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

ctao-dpps-sonarqube[bot] commented 4 weeks ago

Passed

Analysis Details

1 Issue

0 Bugs
0 Vulnerabilities
1 Code Smell

Coverage and Duplications

100.00% Coverage (93.10% Estimated after merge)
0.00% Duplicated Code (0.00% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

ctao-dpps-sonarqube[bot] commented 4 weeks ago

Passed

Analysis Details

0 Issues

0 Bugs
0 Vulnerabilities
0 Code Smells

Coverage and Duplications

100.00% Coverage (93.10% Estimated after merge)
0.00% Duplicated Code (0.00% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

ctao-dpps-sonarqube[bot] commented 3 weeks ago

Passed

Analysis Details

0 Issues

0 Bugs
0 Vulnerabilities
0 Code Smells

Coverage and Duplications

100.00% Coverage (93.10% Estimated after merge)
0.00% Duplicated Code (0.00% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

ctao-dpps-sonarqube[bot] commented 3 weeks ago

Passed

Analysis Details

0 Issues

0 Bugs
0 Vulnerabilities
0 Code Smells

Coverage and Duplications

100.00% Coverage (93.10% Estimated after merge)
0.00% Duplicated Code (0.00% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

tobiaskleiner commented 3 weeks ago

Thanks @GernotMaier for the review. I have now reverted back to with statements and added a few more where they were previously missing. Also now there should be no more general statements to set log levels globally. Let me know if everything is alright now.

ctao-dpps-sonarqube[bot] commented 3 weeks ago

Passed

Analysis Details

0 Issues

0 Bugs
0 Vulnerabilities
0 Code Smells

Coverage and Duplications

No coverage information (93.10% Estimated after merge)
0.00% Duplicated Code (0.00% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube