gammasim / simtools

Tools and applications for the Simulation System of the CTA Observatory.

https://gammasim.github.io/simtools

BSD 3-Clause "New" or "Revised" License

10 stars 1 forks source link

Move functions from test_applications_from_config.py to simtools.testing #1238

Closed GernotMaier closed 1 week ago

GernotMaier commented 1 week ago

The integration test application test_applications_from_config.py contains rather complicated functions to prepare, run, and validate the integration tests.

This PR moves:

all methods to corresponding modules in the simtools.testing area
new modules are testing.configuration and testing.helpers
renamed the module testing.compare_output to testing.validate_output
added unit tests for all modules

Side note: needed to move the pytest package from the test section to the general in pyproject toml, as some of modules in simtools.testing are importing pytest.

I suggest not to do a line-by-line code review, but review the general refactoring and naming. No new functionality has been added, but code moved around. Also not sure if we need a line-by-line review of units tests.

Closes #1174

ctao-dpps-sonarqube[bot] commented 1 week ago

Passed

Analysis Details

12 Issues

0 Bugs
0 Vulnerabilities
12 Code Smells

Coverage and Duplications

100.00% Coverage (93.20% Estimated after merge)
0.00% Duplicated Code (0.00% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

ctao-dpps-sonarqube[bot] commented 1 week ago

Passed

Analysis Details

0 Issues

0 Bugs
0 Vulnerabilities
0 Code Smells

Coverage and Duplications

100.00% Coverage (93.20% Estimated after merge)
0.00% Duplicated Code (0.00% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

ctao-dpps-sonarqube[bot] commented 1 week ago

Passed

Analysis Details

0 Issues

0 Bugs
0 Vulnerabilities
0 Code Smells

Coverage and Duplications

100.00% Coverage (93.20% Estimated after merge)
0.00% Duplicated Code (0.00% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

ctao-dpps-sonarqube[bot] commented 1 week ago

Passed

Analysis Details

0 Issues

0 Bugs
0 Vulnerabilities
0 Code Smells

Coverage and Duplications

100.00% Coverage (93.20% Estimated after merge)
0.00% Duplicated Code (0.00% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

ctao-dpps-sonarqube[bot] commented 1 week ago

Passed

Analysis Details

2 Issues

0 Bugs
0 Vulnerabilities
2 Code Smells

Coverage and Duplications

100.00% Coverage (93.20% Estimated after merge)
0.00% Duplicated Code (0.00% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

ctao-dpps-sonarqube[bot] commented 1 week ago

Passed

Analysis Details

0 Issues

0 Bugs
0 Vulnerabilities
0 Code Smells

Coverage and Duplications

100.00% Coverage (93.20% Estimated after merge)
0.00% Duplicated Code (0.00% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

ctao-dpps-sonarqube[bot] commented 1 week ago

Passed

Analysis Details

0 Issues

0 Bugs
0 Vulnerabilities
0 Code Smells

Coverage and Duplications

100.00% Coverage (93.20% Estimated after merge)
0.00% Duplicated Code (0.00% Estimated after merge)

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

GernotMaier commented 1 week ago

@tobiaskleiner - I think I've addressed your suggestions. Let me know if there is anything else I can do.

Thanks for the review!