gammasim / simtools

Tools and applications for the Simulation System of the CTA Observatory.
https://gammasim.github.io/simtools
BSD 3-Clause "New" or "Revised" License
10 stars 1 forks source link

Remove circular dependency site model - array model #1245

Closed tobiaskleiner closed 2 days ago

ctao-dpps-sonarqube[bot] commented 3 days ago

Passed

Analysis Details

0 Issues

Coverage and Duplications

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

ctao-dpps-sonarqube[bot] commented 3 days ago

Passed

Analysis Details

0 Issues

Coverage and Duplications

Project ID: gammasim_simtools_AY_ssha9WiFxsX-2oy_w

View in SonarQube

GernotMaier commented 2 days ago

@tobiaskleiner - look at this PR and I think this solution is good. Thanks for catching it.

Do you still see any issues why this PR shouldn't be merged?

tobiaskleiner commented 2 days ago

Thanks for the review. Looks also good from my side. Ready to merge if you approve!